From: Vincent Guittot <vincent.guittot@linaro.org>
To: Juri Lelli <juri.lelli@arm.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
LAK <linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Mark Brown <broonie@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 4/9] arm: remove wrong CONFIG_PROC_SYSCTL ifdef
Date: Wed, 29 Mar 2017 09:39:01 +0200 [thread overview]
Message-ID: <CAKfTPtBSFVsRGGFGg2oJF=FN5X6XTp7VtpCLORdEL0GqM+cKXQ@mail.gmail.com> (raw)
In-Reply-To: <20170327131825.32134-5-juri.lelli@arm.com>
On 27 March 2017 at 15:18, Juri Lelli <juri.lelli@arm.com> wrote:
> The sysfs cpu_capacity entry for each CPU has nothing to do with
> PROC_FS, nor it's in /proc/sys path.
>
> Remove such ifdef.
>
> Cc: Russell King <linux@arm.linux.org.uk>
> Reported-and-suggested-by: Sudeep Holla <sudeep.holla@arm.com>
> Fixes: 7e5930aaef5d ('ARM: 8622/3: add sysfs cpu_capacity attribute')
> Signed-off-by: Juri Lelli <juri.lelli@arm.com>
Acked-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> arch/arm/kernel/topology.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
> index 4e4af809606a..162c82aeed96 100644
> --- a/arch/arm/kernel/topology.c
> +++ b/arch/arm/kernel/topology.c
> @@ -57,7 +57,6 @@ static void set_capacity_scale(unsigned int cpu, unsigned long capacity)
> per_cpu(cpu_scale, cpu) = capacity;
> }
>
> -#ifdef CONFIG_PROC_SYSCTL
> static ssize_t cpu_capacity_show(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> @@ -114,7 +113,6 @@ static int register_cpu_capacity_sysctl(void)
> return 0;
> }
> subsys_initcall(register_cpu_capacity_sysctl);
> -#endif
>
> #ifdef CONFIG_OF
> struct cpu_efficiency {
> --
> 2.10.0
>
next prev parent reply other threads:[~2017-03-29 7:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 13:18 [PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-03-27 13:18 ` [PATCH v3 1/9] Documentation: arm: fix wrong reference number in DT definition Juri Lelli
2017-03-27 13:18 ` [PATCH v3 2/9] Documentation/ABI: add information about cpu_capacity Juri Lelli
2017-03-27 13:18 ` [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity Juri Lelli
2017-03-29 7:37 ` Vincent Guittot
2017-03-29 8:06 ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 4/9] arm: remove wrong CONFIG_PROC_SYSCTL ifdef Juri Lelli
2017-03-29 7:39 ` Vincent Guittot [this message]
2017-03-27 13:18 ` [PATCH v3 5/9] arm, arm64: factorize common cpu capacity default code Juri Lelli
2017-04-08 16:25 ` Greg KH
2017-04-10 8:18 ` Catalin Marinas
2017-04-10 16:23 ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 6/9] drivers: remove useless comment from base/arch_topology.c Juri Lelli
2017-04-10 13:51 ` Russell King - ARM Linux
2017-04-10 14:02 ` Juri Lelli
2017-04-10 16:33 ` Russell King - ARM Linux
2017-04-11 10:43 ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 7/9] arm,arm64,drivers: reduce scope of cap_parsing_failed Juri Lelli
2017-04-10 8:31 ` Catalin Marinas
2017-03-27 13:18 ` [PATCH v3 8/9] arm,arm64,drivers: move externs in a new header file Juri Lelli
2017-04-10 8:31 ` Catalin Marinas
2017-03-27 13:18 ` [PATCH v3 9/9] arm,arm64,drivers: add a prefix to drivers arch_topology interfaces Juri Lelli
2017-04-10 8:32 ` [PATCH v3 9/9] arm, arm64, drivers: " Catalin Marinas
2017-04-06 14:14 ` [PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-04-10 15:05 ` Russell King - ARM Linux
2017-04-10 16:21 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKfTPtBSFVsRGGFGg2oJF=FN5X6XTp7VtpCLORdEL0GqM+cKXQ@mail.gmail.com' \
--to=vincent.guittot@linaro.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=juri.lelli@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).