linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vincent Guittot <vincent.guittot@linaro.org>
To: Vincent Donnefort <Vincent.Donnefort@arm.com>
Cc: peterz@infradead.org, mingo@redhat.com,
	linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
	Valentin.Schneider@arm.com
Subject: Re: [PATCH v2 2/2] sched/fair: Fix task_fits_capacity() capacity type
Date: Tue, 23 Nov 2021 09:38:40 +0100	[thread overview]
Message-ID: <CAKfTPtBTVQg+vrCWw++Gn+NBfOCJy3PcsthhNLEHNo+Yr5Bw_Q@mail.gmail.com> (raw)
In-Reply-To: <20211118141411.2623521-2-vincent.donnefort@arm.com>

On Thu, 18 Nov 2021 at 15:15, Vincent Donnefort
<vincent.donnefort@arm.com> wrote:
>
> capacity is an unsigned long value, compared with a task utilization which
> is unsigned long as well. There's no need for an intermediate implicit
> long cast.
>
> Fixes: 3b1baa6496e6 ("sched/fair: Add 'group_misfit_task' load-balance type")
> Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>

Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 8fde6e10e24b..26a88975f68a 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -4070,7 +4070,8 @@ static inline void util_est_update(struct cfs_rq *cfs_rq,
>         trace_sched_util_est_se_tp(&p->se);
>  }
>
> -static inline int task_fits_capacity(struct task_struct *p, long capacity)
> +static inline int task_fits_capacity(struct task_struct *p,
> +                                    unsigned long capacity)
>  {
>         return fits_capacity(uclamp_task_util(p), capacity);
>  }
> --
> 2.25.1
>

  reply	other threads:[~2021-11-23  8:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18 14:14 [PATCH v2 1/2] sched/fair: Fix asym_fits_capacity() task_util type Vincent Donnefort
2021-11-18 14:14 ` [PATCH v2 2/2] sched/fair: Fix task_fits_capacity() capacity type Vincent Donnefort
2021-11-23  8:38   ` Vincent Guittot [this message]
2021-12-06 15:20 ` [PATCH v2 1/2] sched/fair: Fix asym_fits_capacity() task_util type Peter Zijlstra
2021-12-07  9:48   ` Vincent Donnefort

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKfTPtBTVQg+vrCWw++Gn+NBfOCJy3PcsthhNLEHNo+Yr5Bw_Q@mail.gmail.com \
    --to=vincent.guittot@linaro.org \
    --cc=Valentin.Schneider@arm.com \
    --cc=Vincent.Donnefort@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).