From: Vincent Guittot <vincent.guittot@linaro.org>
To: Phil Auld <pauld@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Quentin Perret <quentin.perret@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Morten Rasmussen <Morten.Rasmussen@arm.com>
Subject: Re: [PATCH v2 0/8] sched/fair: rework the CFS load balance
Date: Fri, 30 Aug 2019 08:46:53 +0200 [thread overview]
Message-ID: <CAKfTPtBV-KU9zJXwZ7B3ojriTcbyJLek=oUrsJxA8ppbma90nw@mail.gmail.com> (raw)
In-Reply-To: <20190829192305.GD20736@pauld.bos.csb>
Hi Phil,
On Thu, 29 Aug 2019 at 21:23, Phil Auld <pauld@redhat.com> wrote:
>
> On Thu, Aug 01, 2019 at 04:40:16PM +0200 Vincent Guittot wrote:
> > Several wrong task placement have been raised with the current load
> >
> > --
> > 2.7.4
> >
>
> I keep expecting a v3 so I have not dug into all the patches in detail. However, I've
v3 is under preparation
> been working with them from Vincent's tree while they were under development so I thought
> I'd add some results.
Yes. thanks for your help.
>
> The workload is a test our perf team came up with to illustrate the issues we were seeing
> with imbalance in the presence of group scheduling.
>
> On a 4-numa X 20 cpu system (smt on) we run a 76 thread lu.C benchmark from the NAS Parallel
> suite. And at the same time run 2 stress cpu burn processes. The GROUP test puts the
> benchmark and the stress processes each in its own cgroup. The NORMAL case puts them all
> in the first cgroup. The results show first the average number of threads of each type
> running on each of the numa nodes based on sampling taken during the run. This is followed
> by the lu.C benchmark results. There are 3 runs of GROUP and 2 runs of NORMAL shown.
>
> Before (linux-5.3-rc1+ @ a1dc0446d649)
>
> lu.C.x_76_GROUP_1.stress.ps.numa.hist Average 0.00 1.00 1.00
> lu.C.x_76_GROUP_2.stress.ps.numa.hist Average 0.00 1.00 1.00
> lu.C.x_76_GROUP_3.stress.ps.numa.hist Average 0.00 1.00 1.00
> lu.C.x_76_NORMAL_1.stress.ps.numa.hist Average 1.15 0.23 0.00 0.62
> lu.C.x_76_NORMAL_2.stress.ps.numa.hist Average 1.67 0.00 0.00 0.33
>
> lu.C.x_76_GROUP_1.ps.numa.hist Average 30.45 6.95 4.52 34.08
> lu.C.x_76_GROUP_2.ps.numa.hist Average 32.33 8.94 9.21 25.52
> lu.C.x_76_GROUP_3.ps.numa.hist Average 30.45 8.91 12.09 24.55
> lu.C.x_76_NORMAL_1.ps.numa.hist Average 18.54 19.23 19.69 18.54
> lu.C.x_76_NORMAL_2.ps.numa.hist Average 17.25 19.83 20.00 18.92
>
> ============76_GROUP========Mop/s===================================
> min q1 median q3 max
> 2119.92 2418.1 2716.28 3147.82 3579.36
> ============76_GROUP========time====================================
> min q1 median q3 max
> 569.65 660.155 750.66 856.245 961.83
> ============76_NORMAL========Mop/s===================================
> min q1 median q3 max
> 30424.5 31486.4 31486.4 31486.4 32548.4
> ============76_NORMAL========time====================================
> min q1 median q3 max
> 62.65 64.835 64.835 64.835 67.02
>
>
> After (linux-5.3-rc1+ @ a1dc0446d649 + this v2 series pulled from
> Vincent's git on ~8/15)
>
> lu.C.x_76_GROUP_1.stress.ps.numa.hist Average 0.36 1.00 0.64
> lu.C.x_76_GROUP_2.stress.ps.numa.hist Average 1.00 1.00
> lu.C.x_76_GROUP_3.stress.ps.numa.hist Average 1.00 1.00
> lu.C.x_76_NORMAL_1.stress.ps.numa.hist Average 0.23 0.15 0.31 1.31
> lu.C.x_76_NORMAL_2.stress.ps.numa.hist Average 1.00 0.00 0.00 1.00
>
> lu.C.x_76_GROUP_1.ps.numa.hist Average 18.91 18.36 18.91 19.82
> lu.C.x_76_GROUP_2.ps.numa.hist Average 18.36 18.00 19.91 19.73
> lu.C.x_76_GROUP_3.ps.numa.hist Average 18.17 18.42 19.25 20.17
> lu.C.x_76_NORMAL_1.ps.numa.hist Average 19.08 20.00 18.62 18.31
> lu.C.x_76_NORMAL_2.ps.numa.hist Average 18.09 19.91 19.18 18.82
>
> ============76_GROUP========Mop/s===================================
> min q1 median q3 max
> 32304.1 33176 34047.9 34166.8 34285.7
> ============76_GROUP========time====================================
> min q1 median q3 max
> 59.47 59.68 59.89 61.505 63.12
> ============76_NORMAL========Mop/s===================================
> min q1 median q3 max
> 29825.5 32454 32454 32454 35082.5
> ============76_NORMAL========time====================================
> min q1 median q3 max
> 58.12 63.24 63.24 63.24 68.36
>
>
> I had initially tracked this down to two issues. The first was picking the wrong
> group in find_busiest_group due to using the average load. The second was in
> fix_small_imbalance(). The "load" of the lu.C tasks was so low it often failed
> to move anything even when it did find a group that was overloaded (nr_running
> > width). I have two small patches which fix this but since Vincent was embarking
> on a re-work which also addressed this I dropped them.
>
> We've also run a series of performance tests we use to check for regressions and
> did not find any bad results on our workloads and systems.
>
> So...
>
> Tested-by: Phil Auld <pauld@redhat.com>
Thanks for testing
Vincent
>
>
> Cheers,
> Phil
> --
next prev parent reply other threads:[~2019-08-30 6:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 14:40 [PATCH v2 0/8] sched/fair: rework the CFS load balance Vincent Guittot
2019-08-01 14:40 ` [PATCH v2 1/8] sched/fair: clean up asym packing Vincent Guittot
2019-08-01 14:40 ` [PATCH v2 2/8] sched/fair: rename sum_nr_running to sum_h_nr_running Vincent Guittot
2019-08-01 14:40 ` [PATCH v2 3/8] sched/fair: remove meaningless imbalance calculation Vincent Guittot
2019-08-01 14:40 ` [PATCH v2 4/8] sched/fair: rework load_balance Vincent Guittot
2019-08-05 17:07 ` Valentin Schneider
2019-08-26 9:26 ` Vincent Guittot
2019-08-28 10:25 ` Valentin Schneider
2019-08-06 15:56 ` Peter Zijlstra
2019-08-26 9:31 ` Vincent Guittot
2019-08-06 17:17 ` Valentin Schneider
2019-08-07 11:16 ` Valentin Schneider
2019-08-26 10:11 ` Vincent Guittot
2019-08-28 14:19 ` Valentin Schneider
2019-08-29 14:26 ` Vincent Guittot
2019-08-30 14:33 ` Valentin Schneider
2019-08-01 14:40 ` [PATCH v2 5/8] sched/fair: use rq->nr_running when balancing load Vincent Guittot
2019-08-01 14:40 ` [PATCH v2 6/8] sched/fair: use load instead of runnable load Vincent Guittot
2019-08-06 16:07 ` Peter Zijlstra
2019-08-26 15:45 ` Vincent Guittot
2019-08-01 14:40 ` [PATCH v2 7/8] sched/fair: evenly spread tasks when not overloaded Vincent Guittot
2019-08-01 14:40 ` [PATCH v2 8/8] sched/fair: use utilization to select misfit task Vincent Guittot
2019-08-01 16:27 ` Valentin Schneider
2019-08-02 8:29 ` Vincent Guittot
2019-08-02 10:49 ` Valentin Schneider
2019-08-02 12:56 ` [PATCH v3] " Vincent Guittot
2019-08-02 14:27 ` Valentin Schneider
2019-08-05 11:01 ` Valentin Schneider
2019-08-29 19:23 ` [PATCH v2 0/8] sched/fair: rework the CFS load balance Phil Auld
2019-08-30 6:46 ` Vincent Guittot [this message]
[not found] ` <20190809052124.13016-1-hdanton@sina.com>
2019-09-02 13:07 ` [PATCH v2 5/8] sched/fair: use rq->nr_running when balancing load Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKfTPtBV-KU9zJXwZ7B3ojriTcbyJLek=oUrsJxA8ppbma90nw@mail.gmail.com' \
--to=vincent.guittot@linaro.org \
--cc=Morten.Rasmussen@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=quentin.perret@arm.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).