From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6595AC433F5 for ; Fri, 15 Oct 2021 17:57:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45CD360F93 for ; Fri, 15 Oct 2021 17:57:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242417AbhJOR7b (ORCPT ); Fri, 15 Oct 2021 13:59:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242413AbhJOR71 (ORCPT ); Fri, 15 Oct 2021 13:59:27 -0400 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B672DC061570 for ; Fri, 15 Oct 2021 10:57:20 -0700 (PDT) Received: by mail-yb1-xb2f.google.com with SMTP id v195so24756123ybb.0 for ; Fri, 15 Oct 2021 10:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=97jlEBeOWc1FuL5gX+2pJvQdPP9/uMhHJPjVq16mCeQ=; b=MfHP24zhRLTuEfttABUfFJeWZfEBNb910OdOqWVEBQhhPVlUDYRrFuts+dEd5ygr9d MxSmcw/PmZqYmNGJ223VOCzpy1pc8AhlQ9XMqDhhsnwbXhbpj71lINakeQHVeeGGJJ0Y JqPV+Ttg6PqKTp6GxgQ/jei1ZawiFJm+uP41w+LrQHkdiGJ8hhIe2dVdA5CEvmmlRzU+ SP9p0jo3mJYeuBRqmVdQ41/2usLdwF4gUqoynSdCYxny5oXVomjFZIsXITdSPh8IQhMm NyS9UfaJ0XaN+p25MeSmNsSxIyi3Er6YIopr+S/UmF0nDynQxXKWD3RUOAbBVDNzSo1g LHtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=97jlEBeOWc1FuL5gX+2pJvQdPP9/uMhHJPjVq16mCeQ=; b=43sTOKLIBcitC6n56KzZ5xWW2Yh+PYkGLqKWZsjOi9rgZbOSHTGTX3+ubC6QSdVU7m gkn5ijeCN2vTBNTGoqCDF0qCdVoMHvAlU36jJbNQ1O3ATZUStLRF7vqGRDXMq2+Id/BF wEHbP7EX8vD5m3YNH4MD2roOaLMsAJJIRUOO0xnjp69vPuxE6UXwM24mfVxnesSgPyFK ksyUHiD9yeVsajgLzeHyInYqL4+CpW05PvFN1ddSBapEwxGUQvxLehP7uZXTXVxmE9ug C8ZzZXVY3gMs6+vCrr9VJgu+eKlwoUYveXB4vQS7hF9ealcE9kq46psrMN3r699gW3c9 9SmA== X-Gm-Message-State: AOAM531v/0DCBnE7iZcX0Vd8M8JwKDOVmkVSodQrarKoTNk5hCElO7v7 q7rQ2UD3FGzdLsN27hPREHAjiIxXOnK4xdFvujYUOQ== X-Google-Smtp-Source: ABdhPJw/aouEmbvTZNiox/xkSdKoF5AmKM5SbeLN9/dPjuA7usq/b6BP8h1GSOVxAcl0lbxalan4yAsp0xJL3jcUMzs= X-Received: by 2002:a25:2f8e:: with SMTP id v136mr13797663ybv.350.1634320639885; Fri, 15 Oct 2021 10:57:19 -0700 (PDT) MIME-Version: 1.0 References: <20211015124654.18093-1-vincent.guittot@linaro.org> <20211015124654.18093-5-vincent.guittot@linaro.org> <20211015174241.GJ174703@worktop.programming.kicks-ass.net> In-Reply-To: <20211015174241.GJ174703@worktop.programming.kicks-ass.net> From: Vincent Guittot Date: Fri, 15 Oct 2021 19:57:08 +0200 Message-ID: Subject: Re: [PATCH v2 4/4] sched/fair: Remove sysctl_sched_migration_cost condition To: Peter Zijlstra Cc: Ingo Molnar , Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , linux-kernel , Tim Chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Oct 2021 at 19:42, Peter Zijlstra wrote: > > On Fri, Oct 15, 2021 at 02:46:54PM +0200, Vincent Guittot wrote: > > With a default value of 500us, sysctl_sched_migration_cost is > > significanlty higher than the cost of load_balance. Remove the > > condition and rely on the sd->max_newidle_lb_cost to abort > > newidle_balance. > > > > Suggested-by: Peter Zijlstra (Intel) > > Signed-off-by: Vincent Guittot > > This is separate and not folded in for ease of bisection? yes ease bisect and ease revert if finally there is a regression