From: Vincent Guittot <vincent.guittot@linaro.org>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Patrick Bellasi <patrick.bellasi@matbug.net>,
Quentin Perret <qperret@google.com>,
Qais Yousef <qais.yousef@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>
Subject: Re: [PATCH v2 1/4] sched/uclamp: Make uclamp_util_*() helpers use and return UL values
Date: Wed, 4 Dec 2019 16:22:44 +0100 [thread overview]
Message-ID: <CAKfTPtC-9nxGCAq8ck0Av6zuqCySvO87oP4hhBE=qKL3gxu+ow@mail.gmail.com> (raw)
In-Reply-To: <20191203155907.2086-2-valentin.schneider@arm.com>
On Tue, 3 Dec 2019 at 17:02, Valentin Schneider
<valentin.schneider@arm.com> wrote:
>
> Vincent pointed out recently that the canonical type for utilization
> values is 'unsigned long'. Internally uclamp uses 'unsigned int' values for
> cache optimization, but this doesn't have to be exported to its users.
>
> Make the uclamp helpers that deal with utilization use and return unsigned
> long values.
>
> Reviewed-by: Quentin Perret <qperret@google.com>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> ---
> kernel/sched/sched.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 280a3c735935..f1d035e5df7e 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -2303,15 +2303,15 @@ static inline void cpufreq_update_util(struct rq *rq, unsigned int flags) {}
> unsigned int uclamp_eff_value(struct task_struct *p, enum uclamp_id clamp_id);
Why not changing uclamp_eff_value to return unsigned long too ? The
returned value represents a utilization to be compared with other
utilization value
>
> static __always_inline
> -unsigned int uclamp_util_with(struct rq *rq, unsigned int util,
> - struct task_struct *p)
> +unsigned long uclamp_util_with(struct rq *rq, unsigned long util,
> + struct task_struct *p)
> {
> - unsigned int min_util = READ_ONCE(rq->uclamp[UCLAMP_MIN].value);
> - unsigned int max_util = READ_ONCE(rq->uclamp[UCLAMP_MAX].value);
> + unsigned long min_util = READ_ONCE(rq->uclamp[UCLAMP_MIN].value);
> + unsigned long max_util = READ_ONCE(rq->uclamp[UCLAMP_MAX].value);
>
> if (p) {
> - min_util = max(min_util, uclamp_eff_value(p, UCLAMP_MIN));
> - max_util = max(max_util, uclamp_eff_value(p, UCLAMP_MAX));
> + min_util = max_t(unsigned long, min_util, uclamp_eff_value(p, UCLAMP_MIN));
As mentioned above, uclamp_eff_value should return an unsigned long
> + max_util = max_t(unsigned long, max_util, uclamp_eff_value(p, UCLAMP_MAX));
> }
>
> /*
> @@ -2325,17 +2325,17 @@ unsigned int uclamp_util_with(struct rq *rq, unsigned int util,
> return clamp(util, min_util, max_util);
> }
>
> -static inline unsigned int uclamp_util(struct rq *rq, unsigned int util)
> +static inline unsigned long uclamp_util(struct rq *rq, unsigned long util)
> {
> return uclamp_util_with(rq, util, NULL);
> }
> #else /* CONFIG_UCLAMP_TASK */
> -static inline unsigned int uclamp_util_with(struct rq *rq, unsigned int util,
> - struct task_struct *p)
> +static inline unsigned long uclamp_util_with(struct rq *rq, unsigned long util,
> + struct task_struct *p)
> {
> return util;
> }
> -static inline unsigned int uclamp_util(struct rq *rq, unsigned int util)
> +static inline unsigned long uclamp_util(struct rq *rq, unsigned long util)
> {
> return util;
> }
> --
> 2.24.0
>
next prev parent reply other threads:[~2019-12-04 15:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 15:59 [PATCH v2 0/4] sched/fair: Task placement biasing using uclamp Valentin Schneider
2019-12-03 15:59 ` [PATCH v2 1/4] sched/uclamp: Make uclamp_util_*() helpers use and return UL values Valentin Schneider
2019-12-04 15:22 ` Vincent Guittot [this message]
2019-12-04 16:03 ` Valentin Schneider
2019-12-04 16:12 ` Vincent Guittot
2019-12-04 16:25 ` Rainer Sickinger
2019-12-04 17:15 ` Valentin Schneider
2019-12-04 17:29 ` Vincent Guittot
2019-12-04 17:35 ` Valentin Schneider
2019-12-10 18:09 ` Dietmar Eggemann
2019-12-10 18:31 ` Valentin Schneider
2019-12-03 15:59 ` [PATCH v2 2/4] sched/uclamp: Rename uclamp_util_*() into uclamp_rq_util_*() Valentin Schneider
2019-12-03 15:59 ` [PATCH v2 3/4] sched/fair: Make task_fits_capacity() consider uclamp restrictions Valentin Schneider
2019-12-10 17:07 ` Dietmar Eggemann
2019-12-10 17:10 ` Valentin Schneider
2019-12-03 15:59 ` [PATCH v2 4/4] sched/fair: Make feec() " Valentin Schneider
2019-12-10 18:23 ` Dietmar Eggemann
2019-12-10 18:35 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKfTPtC-9nxGCAq8ck0Av6zuqCySvO87oP4hhBE=qKL3gxu+ow@mail.gmail.com' \
--to=vincent.guittot@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=qperret@google.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).