From: Vincent Guittot <vincent.guittot@linaro.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/numa: use runnable_avg to classify node
Date: Thu, 27 Aug 2020 17:43:11 +0200 [thread overview]
Message-ID: <CAKfTPtCRmts+qH+hexKbhZ7595zGs1U3Q5V4-XzHgpU0dJd+1Q@mail.gmail.com> (raw)
In-Reply-To: <20200827153534.GF3033@suse.de>
On Thu, 27 Aug 2020 at 17:35, Mel Gorman <mgorman@suse.de> wrote:
>
> On Tue, Aug 25, 2020 at 02:18:18PM +0200, Vincent Guittot wrote:
> > Use runnable_avg to classify numa node state similarly to what is done for
> > normal load balancer. This helps to ensure that numa and normal balancers
> > use the same view of the state of the system.
> >
> > - large arm64system: 2 nodes / 224 CPUs
> > hackbench -l (256000/#grp) -g #grp
> >
> > grp tip/sched/core +patchset improvement
> > 1 14,008(+/- 4,99 %) 13,800(+/- 3.88 %) 1,48 %
> > 4 4,340(+/- 5.35 %) 4.283(+/- 4.85 %) 1,33 %
> > 16 3,357(+/- 0.55 %) 3.359(+/- 0.54 %) -0,06 %
> > 32 3,050(+/- 0.94 %) 3.039(+/- 1,06 %) 0,38 %
> > 64 2.968(+/- 1,85 %) 3.006(+/- 2.92 %) -1.27 %
> > 128 3,290(+/-12.61 %) 3,108(+/- 5.97 %) 5.51 %
> > 256 3.235(+/- 3.95 %) 3,188(+/- 2.83 %) 1.45 %
> >
> > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
>
> The testing was a mixed bag of wins and losses but wins more than it
> loses. Biggest loss was a 9.04% regression on nas-SP using openmp for
> parallelisation on Zen1. Biggest win was around 8% gain running
> specjbb2005 on Zen2 (with some major gains of up to 55% for some thread
> counts). Most workloads were stable across multiple Intel and AMD
> machines.
>
> There were some oddities in changes in NUMA scanning rate but that is
> likely a side-effect because the locality over time for the same loads
> did not look obviously worse. There was no negative result I could point
> at that was not offset by a positive result elsewhere. Given it's not
> a univeral win or loss, matching numa and lb balancing as closely as
> possible is best so
>
> Reviewed-by: Mel Gorman <mgorman@suse.de>
Thanks.
I will try to reproduce the nas-SP test on my setup to see what is going one
Vincent
>
> Thanks.
>
> --
> Mel Gorman
> SUSE Labs
next prev parent reply other threads:[~2020-08-27 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 12:18 [PATCH] sched/numa: use runnable_avg to classify node Vincent Guittot
2020-08-25 13:58 ` Mel Gorman
2020-08-25 15:52 ` Vincent Guittot
2020-08-27 15:35 ` Mel Gorman
2020-08-27 15:43 ` Vincent Guittot [this message]
2020-08-27 18:22 ` Mel Gorman
2020-08-28 6:47 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKfTPtCRmts+qH+hexKbhZ7595zGs1U3Q5V4-XzHgpU0dJd+1Q@mail.gmail.com \
--to=vincent.guittot@linaro.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).