From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D4BC352AA for ; Wed, 2 Oct 2019 06:32:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 058AB2086A for ; Wed, 2 Oct 2019 06:32:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WNwU+kt9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbfJBG20 (ORCPT ); Wed, 2 Oct 2019 02:28:26 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:41233 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbfJBG2Z (ORCPT ); Wed, 2 Oct 2019 02:28:25 -0400 Received: by mail-lf1-f68.google.com with SMTP id r2so11766335lfn.8 for ; Tue, 01 Oct 2019 23:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TTszmpSpMPlVv5NO5j52vopWvFhJ/hDvGIs1sInZeE0=; b=WNwU+kt9M0gQO+bZUFeCQ2Uy2rYvSmCZlOXfGwcN9Ken31ATJxZchpQslOXJXpvCp/ m/1ISDxuTA5dgvkKN8PAmHX0P7+EMq52GMV/QjsKpuIAsIuYlPhRXylBNiZ3DJswaVqY ZhXagFuEmGNISZGuRh0PlQlNSgkd2XLcnf5ETgfm/wviUq+MaFZ9ee/WxFEKmde/jfsc imQSWngBTadQ0kAhR38khptmuHTo7QdUiI59o2l7rI5kF/HJjxz2eX8EoGxx2Z1sU3lY JFMkx4eZS44bE14qZGWpCnBpOyMk5QFzC4dMEFZsDDqt4SNSQ3Ju4nYtt/NPXQRVuupp s1pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TTszmpSpMPlVv5NO5j52vopWvFhJ/hDvGIs1sInZeE0=; b=q01K0CjGNv56HVtUrbPEGLnPSBIiMM5pkqzPL5cZ26/tSYx8Xumb05wgkZqf6cULIq yIqqSJnlsvYVRe9qOmxexfxf7BNsR1ghbFwYe3AOT6kj4FenycDK2/WTBngVygYBZ638 Rz9rGWMATiO8i48BAbMZSnqqixQUkAAeOabIo8IHVTsNN+/ng396H87XGQ5MuJtD4aKq rKl63NiWCMPnYRWo9fcACyO5LmYS7ocuO4Irjj0Lk7redAUGm3IOpM1D0r3weeJzJfeo qLTYfwYdsRCWbVadBC1WyGQV7rPiJvtvWjp35n6+1MPokOtGMLWUIkiYw4WO7m0zmwFK iTyQ== X-Gm-Message-State: APjAAAWM6qaSvXo2iZYerTr0WwCjPYs5xJkaTdnjBDA6K6q0yR3TihNf iZAhWIINF5Hdp8dMB7LQcasTiPd+gF/7nq9Cuh5TNw== X-Google-Smtp-Source: APXvYqxfpQj299sIJX4i65rHVAQmPwXXj80RqmfBCbpkjz94WBQjAB+NioCF61EeH+wGUijNRXt2XvGJdXZymZAgwno= X-Received: by 2002:ac2:554e:: with SMTP id l14mr1208452lfk.32.1569997703468; Tue, 01 Oct 2019 23:28:23 -0700 (PDT) MIME-Version: 1.0 References: <1568878421-12301-1-git-send-email-vincent.guittot@linaro.org> <1568878421-12301-4-git-send-email-vincent.guittot@linaro.org> In-Reply-To: From: Vincent Guittot Date: Wed, 2 Oct 2019 08:28:11 +0200 Message-ID: Subject: Re: [PATCH v3 03/10] sched/fair: remove meaningless imbalance calculation To: Valentin Schneider Cc: linux-kernel , Ingo Molnar , Peter Zijlstra , Phil Auld , Srikar Dronamraju , Quentin Perret , Dietmar Eggemann , Morten Rasmussen , Hillf Danton Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Oct 2019 at 19:12, Valentin Schneider wrote: > > On 19/09/2019 08:33, Vincent Guittot wrote: > > clean up load_balance and remove meaningless calculation and fields before > > adding new algorithm. > > > > Signed-off-by: Vincent Guittot > > We'll probably want to squash the removal of fix_small_imbalance() in the > actual rework (patch 04) to not make this a regression bisect honeypot. Yes that's the plan. Peter asked to split the patch to ease the review > Other than that: > > Reviewed-by: Valentin Schneider