From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751165AbcGMMko (ORCPT ); Wed, 13 Jul 2016 08:40:44 -0400 Received: from mail-lf0-f52.google.com ([209.85.215.52]:33038 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750956AbcGMMkg (ORCPT ); Wed, 13 Jul 2016 08:40:36 -0400 MIME-Version: 1.0 In-Reply-To: <1466615004-3503-7-git-send-email-morten.rasmussen@arm.com> References: <1466615004-3503-1-git-send-email-morten.rasmussen@arm.com> <1466615004-3503-7-git-send-email-morten.rasmussen@arm.com> From: Vincent Guittot Date: Wed, 13 Jul 2016 14:40:14 +0200 Message-ID: Subject: Re: [PATCH v2 06/13] sched: Store maximum per-cpu capacity in root domain To: Morten Rasmussen Cc: Peter Zijlstra , "mingo@redhat.com" , Dietmar Eggemann , Yuyang Du , mgalbraith@suse.de, linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22 June 2016 at 19:03, Morten Rasmussen wrote: > From: Dietmar Eggemann > > To be able to compare the capacity of the target cpu with the highest > available cpu capacity, store the maximum per-cpu capacity in the root > domain. I thought that the capacity of all CPUS were built so the highest capacity of the CPU of the system is 1024 for big LITTLE system . So this patch doesn't seem necessary for big.LITTLE system > > cc: Ingo Molnar > cc: Peter Zijlstra > > Signed-off-by: Dietmar Eggemann > Signed-off-by: Morten Rasmussen > --- > kernel/sched/core.c | 9 +++++++++ > kernel/sched/sched.h | 2 ++ > 2 files changed, 11 insertions(+) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index fe39118ffdfb..5093765e9930 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -6855,6 +6855,7 @@ static int build_sched_domains(const struct cpumask *cpu_map, > enum s_alloc alloc_state; > struct sched_domain *sd; > struct s_data d; > + struct rq *rq = NULL; > int i, ret = -ENOMEM; > > alloc_state = __visit_domain_allocation_hell(&d, cpu_map); > @@ -6905,11 +6906,19 @@ static int build_sched_domains(const struct cpumask *cpu_map, > /* Attach the domains */ > rcu_read_lock(); > for_each_cpu(i, cpu_map) { > + rq = cpu_rq(i); > sd = *per_cpu_ptr(d.sd, i); > cpu_attach_domain(sd, d.rd, i); > + > + if (rq->cpu_capacity_orig > rq->rd->max_cpu_capacity) > + rq->rd->max_cpu_capacity = rq->cpu_capacity_orig; > } > rcu_read_unlock(); > > + if (rq) > + pr_info("span: %*pbl (max cpu_capacity = %lu)\n", > + cpumask_pr_args(cpu_map), rq->rd->max_cpu_capacity); > + > ret = 0; > error: > __free_domain_allocs(&d, alloc_state, cpu_map); > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index 72f1f3087b04..3e9904ef224f 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -564,6 +564,8 @@ struct root_domain { > */ > cpumask_var_t rto_mask; > struct cpupri cpupri; > + > + unsigned long max_cpu_capacity; > }; > > extern struct root_domain def_root_domain; > -- > 1.9.1 >