From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755648AbcFQQPS (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Jun 2016 12:15:18 -0400
Received: from mail-lf0-f44.google.com ([209.85.215.44]:32803 "EHLO
	mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752780AbcFQQPP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Jun 2016 12:15:15 -0400
MIME-Version: 1.0
In-Reply-To: <20160617160239.GL30927@twins.programming.kicks-ass.net>
References: <20160617120136.064100812@infradead.org> <20160617120454.150630859@infradead.org>
 <CAKfTPtAUtteP0V5-1u2n0YFDdFbZfwSqigHjOfM32Vbw3iAPbg@mail.gmail.com>
 <20160617142814.GT30154@twins.programming.kicks-ass.net> <20160617160239.GL30927@twins.programming.kicks-ass.net>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Fri, 17 Jun 2016 18:14:54 +0200
Message-ID: <CAKfTPtDTxb7KqPzwZjEVQVd9x84v2By_3v2xhbPp3X4tEJ1n3w@mail.gmail.com>
Subject: Re: [PATCH 4/4] sched,fair: Fix PELT integrity for new tasks
To: Peter Zijlstra <peterz@infradead.org>
Cc: Yuyang Du <yuyang.du@intel.com>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Mike Galbraith <umgwanakikbuti@gmail.com>,
        Benjamin Segall <bsegall@google.com>, Paul Turner <pjt@google.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Matt Fleming <matt@codeblueprint.co.uk>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 17 June 2016 at 18:02, Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, Jun 17, 2016 at 04:28:14PM +0200, Peter Zijlstra wrote:
>> On Fri, Jun 17, 2016 at 04:09:01PM +0200, Vincent Guittot wrote:
>> > >
>> > > Scenario 1: switch to fair class
>> > >
>> > >   p->sched_class = fair_class;
>> > >   if (queued)
>> > >     enqueue_task(p);
>> > >       ...
>> > >         enqueue_entity()
>> > >           enqueue_entity_load_avg()
>> > >             migrated = !sa->last_update_time (true)
>> > >             if (migrated)
>> > >               attach_entity_load_avg()
>> > >   check_class_changed()
>> > >     switched_from() (!fair)
>> > >     switched_to()   (fair)
>> > >       switched_to_fair()
>> > >         attach_entity_load_avg()
>>
>> > > @@ -733,18 +737,21 @@ void post_init_entity_util_avg(struct sc
>> > >                 }
>> > >                 sa->util_sum = sa->util_avg * LOAD_AVG_MAX;
>> > >         }
>> > > +
>> > > +       update_cfs_rq_load_avg(cfs_rq_clock_task(cfs_rq), cfs_rq, false);
>> > > +       attach_entity_load_avg(cfs_rq, se);
>> >
>> > A new RT task will be attached and will contribute to the load until
>> > it decays to 0
>
>> > Should we detach it for non cfs task ?
>
> Right, an attach + detach, which basically ends up being:
>
>> > We just want to update
>> > last_update_time of RT task to something different from 0
>
> this. That's the same as starting as fair and then doing
> switched_from_fair().

Yes that's also a possibility to add a way to call switched_from_fair
for non fair task

>
> So yes, ho-humm, how to go about doing that bestest. Lemme have a play.
>