From: Vincent Guittot <vincent.guittot@linaro.org>
To: Parth Shah <parth@linux.ibm.com>
Cc: Hillf Danton <hdanton@sina.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Patrick Bellasi <patrick.bellasi@matbug.net>,
Valentin Schneider <valentin.schneider@arm.com>,
Pavel Machek <pavel@ucw.cz>, Doug Smythies <dsmythies@telus.net>,
Quentin Perret <qperret@qperret.net>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [RFC v5 4/6] sched/fair: Tune task wake-up logic to pack small background tasks on fewer cores
Date: Wed, 9 Oct 2019 13:34:06 +0200 [thread overview]
Message-ID: <CAKfTPtDghQrjK=4Pd0RbvwbQTU1SP88nVp6NLkNitk+07UfadA@mail.gmail.com> (raw)
In-Reply-To: <d4c936d9-c99f-e50d-95c9-0732ae45d1b9@linux.ibm.com>
On Wed, 9 Oct 2019 at 11:23, Parth Shah <parth@linux.ibm.com> wrote:
>
>
>
> On 10/8/19 6:58 PM, Hillf Danton wrote:
> >
> > On Mon, 7 Oct 2019 14:00:49 +0530 Parth Shah wrote:
> >> +/*
> >> + * Try to find a non idle core in the system based on few heuristics:
> >> + * - Keep track of overutilized (>80% util) and busy (>12.5% util) CPUs
> >> + * - If none CPUs are busy then do not select the core for task packing
> >> + * - If atleast one CPU is busy then do task packing unless overutilized CPUs
> >> + * count is < busy/2 CPU count
> >> + * - Always select idle CPU for task packing
> >> + */
> >> +static int select_non_idle_core(struct task_struct *p, int prev_cpu, int target)
> >> +{
> >> + struct cpumask *cpus = this_cpu_cpumask_var_ptr(turbo_sched_mask);
> >> + int iter_cpu, sibling;
> >> +
> >> + cpumask_and(cpus, cpu_online_mask, p->cpus_ptr);
> >> +
> >> + for_each_cpu_wrap(iter_cpu, cpus, prev_cpu) {
> >> + int idle_cpu_count = 0, non_idle_cpu_count = 0;
> >> + int overutil_cpu_count = 0;
> >> + int busy_cpu_count = 0;
> >> + int best_cpu = iter_cpu;
> >> +
> >> + for_each_cpu(sibling, cpu_smt_mask(iter_cpu)) {
> >> + __cpumask_clear_cpu(sibling, cpus);
> >> + if (idle_cpu(iter_cpu)) {
> >
> > Would you please elaborate the reasons that the iter cpu is checked idle
> > more than once for finding a busy core?
> >
>
> Thanks for looking at the patches.
> Could you please point me out where iter_cpu is checked more than once?
I think that point is that you have a sibling that there is
for_each_cpu(sibling, cpu_smt_mask(iter_cpu) but you never use sibling
in the loop except for clearing it on the cpumask cpus
All the tests are done with iter_cpu so you will test several time
iter_cpus but never the other sibling
Should you use sibling instead ?
>
> >> + idle_cpu_count++;
> >> + best_cpu = iter_cpu;
> >> + } else {
> >> + non_idle_cpu_count++;
> >> + if (cpu_overutilized(iter_cpu))
> >> + overutil_cpu_count++;
> >> + if (is_cpu_busy(cpu_util(iter_cpu)))
> >> + busy_cpu_count++;
> >> + }
> >> + }
> >> +
> >
>
next prev parent reply other threads:[~2019-10-09 11:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 8:30 [RFC v5 0/6] TurboSched: A scheduler for sustaining Turbo Frequencies for longer durations Parth Shah
2019-10-07 8:30 ` [RFC v5 1/6] sched/core: Add manual background task classification using sched_setattr syscall Parth Shah
2019-10-07 8:30 ` [RFC v5 2/6] sched: Introduce switch to enable TurboSched for task packing Parth Shah
2019-10-07 8:30 ` [RFC v5 3/6] sched/core: Update turbo_sched count only when required Parth Shah
2019-10-07 8:30 ` [RFC v5 4/6] sched/fair: Tune task wake-up logic to pack small background tasks on fewer cores Parth Shah
2019-10-07 12:19 ` Vincent Guittot
2019-10-07 16:53 ` Parth Shah
2019-10-08 16:20 ` Vincent Guittot
2019-10-09 8:46 ` Parth Shah
2019-10-08 16:52 ` Dietmar Eggemann
2019-10-09 8:57 ` Parth Shah
2019-10-09 14:26 ` Dietmar Eggemann
2019-10-09 17:02 ` Parth Shah
2019-10-10 14:53 ` Dietmar Eggemann
2019-10-07 8:30 ` [RFC v5 5/6] sched/fair: Provide arch hook to find domain for non idle core search scan Parth Shah
2019-10-07 8:30 ` [RFC v5 6/6] powerpc: Set turbo domain to NUMA node for task packing Parth Shah
[not found] ` <20191008132842.6612-1-hdanton@sina.com>
2019-10-09 9:22 ` [RFC v5 4/6] sched/fair: Tune task wake-up logic to pack small background tasks on fewer cores Parth Shah
2019-10-09 11:34 ` Vincent Guittot [this message]
2019-10-09 16:55 ` Parth Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKfTPtDghQrjK=4Pd0RbvwbQTU1SP88nVp6NLkNitk+07UfadA@mail.gmail.com' \
--to=vincent.guittot@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=dsmythies@telus.net \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=parth@linux.ibm.com \
--cc=patrick.bellasi@matbug.net \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=qperret@qperret.net \
--cc=rafael.j.wysocki@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).