From: Jarod Wilson <jarod@redhat.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized
Date: Mon, 15 Mar 2021 14:20:49 -0400 [thread overview]
Message-ID: <CAKfmpSfJ-t6pPC+Bwu0UrWH9w9edgcM-Y+qKAXBNx0NSXw_ZEQ@mail.gmail.com> (raw)
In-Reply-To: <87lfasaxug.fsf@tynnyri.adurom.net>
On Fri, Mar 12, 2021 at 4:04 PM Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Jarod Wilson <jarod@redhat.com> writes:
>
> > Build currently fails with -Werror=maybe-uninitialized set:
> >
> > net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs':
> > net/wireless/nl80211.c:124:44: error: 'wdev_id' may be used
> > uninitialized in this function [-Werror=maybe-uninitialized]
>
> Really, build fails? Is -Werror enabled by default now? I hope not.
Don't think so. But we (Red Hat) build all our kernels with a fair
amount of extra error-checking enabled.
--
Jarod Wilson
jarod@redhat.com
prev parent reply other threads:[~2021-03-15 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 16:36 [PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized Jarod Wilson
2021-03-12 21:03 ` Kalle Valo
2021-03-15 18:20 ` Jarod Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKfmpSfJ-t6pPC+Bwu0UrWH9w9edgcM-Y+qKAXBNx0NSXw_ZEQ@mail.gmail.com \
--to=jarod@redhat.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).