From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753623AbaE0T3A (ORCPT ); Tue, 27 May 2014 15:29:00 -0400 Received: from mail-qg0-f44.google.com ([209.85.192.44]:58764 "EHLO mail-qg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753589AbaE0T26 (ORCPT ); Tue, 27 May 2014 15:28:58 -0400 MIME-Version: 1.0 Reply-To: mtk.manpages@gmail.com In-Reply-To: <20140527192115.GD25474@kernel.org> References: <536101C9.9090601@gmail.com> <20140512143451.GB13801@kernel.org> <20140521210535.GA5414@kernel.org> <537E0961.8040005@gmail.com> <20140526134647.GB8176@kernel.org> <20140526211706.GA25474@kernel.org> <5384BEC5.2080607@gmail.com> <20140527192115.GD25474@kernel.org> From: "Michael Kerrisk (man-pages)" Date: Tue, 27 May 2014 21:28:37 +0200 Message-ID: Subject: Re: [PATCH/RFC] Re: recvmmsg() timeout behavior strangeness [RESEND] To: Arnaldo Carvalho de Melo Cc: lkml , "linux-man@vger.kernel.org" , netdev , =?UTF-8?B?T25kxZllaiBCw61sa2E=?= , Caitlin Bestler , Neil Horman , Elie De Brauwer , David Miller , Steven Whitehouse , =?UTF-8?Q?R=C3=A9mi_Denis=2DCourmont?= , Paul Moore , Chris Friesen , Arnaldo Carvalho de Melo Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 27, 2014 at 9:21 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, May 27, 2014 at 06:35:17PM +0200, Michael Kerrisk (man-pages) escreveu: >> On 05/26/2014 11:17 PM, Arnaldo Carvalho de Melo wrote: >> > Can you try the attached patch on top of the first one? > >> Patches on patches is a way to make your testers work unnecessarily >> harder. Also, it means that anyone else who was interested in this > > It was meant to highlight the changes with regard to the previous patch, > i.e. to make things easier for reviewing. (I don't think that works...) >> thread likely got lost at this point, because they probably didn't >> save the first patch. All of this to say: it makes life much easier >> if you provide a complete new self-contained patch on each iteration. > > If you prefer it that way, find one attached, that I was about to send > (but you can wait till I use your program to test it ;-) ) > >> > It starts adding explicit parentheses on a ternary, as David requested, >> > and then should return the remaining timeouts in cases like signals, >> > etc. >> > >> > Please let me know if this is enough. >> >> Nope, it doesn't fix the problem. (I applied both patches against 3.15-rc7) > > What was the problem experienced? The problem is that after EINTR, the timeout is not updated with the remaining time until expiry. (This was true with just patch 1 applied, and is also true with both patch 1 and patch 2 applied.) Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/