From: Alexander Duyck <alexander.duyck@gmail.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: Netdev <netdev@vger.kernel.org>,
Timur Tabi <timur@codeaurora.org>,
sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] e1000: eliminate duplicate barriers on weakly-ordered archs
Date: Thu, 15 Mar 2018 17:25:17 -0700 [thread overview]
Message-ID: <CAKgT0UcfEwL9Jas149a=h3R4zeu4oA=uywJ9dpYD9kDdnpWQFA@mail.gmail.com> (raw)
In-Reply-To: <39dc5bb4-02b1-bf7e-fbfc-17fc484e4fb7@codeaurora.org>
On Thu, Mar 15, 2018 at 4:30 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
> On 3/14/2018 9:41 PM, Alexander Duyck wrote:
>>> }
>>>
>> So you missed the writel in e1000_xmit_frame. You should probably get
>> that one too while you are doing these updates. The wmb() is in
>> e1000_tx_queue().
>>
>
> I brought wmb() outside along with the next descriptor assignment to be
> similar to the rest of the other code.
>
> if wmb() and writel() are not visible in the same function, let's not touch
> the code.
Maybe for e1000 we should just skip the driver entirely. Odds are you
aren't going to have any e1000 parts running on ARM anyway since most
of them are legacy PCI or PCI-X parts that were made over 10 years
ago. Most of your efforts would probably be best spent on igb, igbvf,
ixgbe, ixgbevf, i40e, i40evf, and fm10k.
next prev parent reply other threads:[~2018-03-16 0:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 3:20 [PATCH 1/7] i40e/i40evf: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-14 3:20 ` [PATCH 2/7] ixgbe: eliminate " Sinan Kaya
2018-03-15 1:47 ` Alexander Duyck
2018-03-14 3:20 ` [PATCH 3/7] RDMA/qedr: " Sinan Kaya
2018-03-14 4:12 ` Jason Gunthorpe
2018-03-14 12:06 ` okaya
2018-03-15 22:23 ` Jason Gunthorpe
2018-03-14 3:20 ` [PATCH 4/7] igbvf: " Sinan Kaya
2018-03-15 1:48 ` Alexander Duyck
2018-03-14 3:20 ` [PATCH 5/7] igb: " Sinan Kaya
2018-03-15 1:50 ` Alexander Duyck
2018-03-14 3:20 ` [PATCH 6/7] e1000: " Sinan Kaya
2018-03-15 1:41 ` Alexander Duyck
2018-03-15 23:30 ` Sinan Kaya
2018-03-16 0:25 ` Alexander Duyck [this message]
2018-03-16 0:50 ` Sinan Kaya
2018-03-14 3:20 ` [PATCH 7/7] ixgbevf: " Sinan Kaya
2018-03-14 5:08 ` Timur Tabi
2018-03-14 12:13 ` okaya
2018-03-14 21:49 ` Alexander Duyck
2018-03-14 22:57 ` Sinan Kaya
2018-03-15 1:44 ` Alexander Duyck
2018-03-15 2:17 ` Sinan Kaya
2018-03-15 14:32 ` Alexander Duyck
2018-03-15 16:21 ` Sinan Kaya
2018-03-15 16:27 ` Sinan Kaya
2018-03-15 16:58 ` Alexander Duyck
2018-03-15 1:45 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKgT0UcfEwL9Jas149a=h3R4zeu4oA=uywJ9dpYD9kDdnpWQFA@mail.gmail.com' \
--to=alexander.duyck@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=sulrich@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).