From: Alexander Duyck <alexander.duyck@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci <linux-pci@vger.kernel.org>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Johannes Berg <johannes.berg@intel.com>,
linuxwifi@intel.com, Netdev <netdev@vger.kernel.org>,
linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com,
LKML <linux-kernel@vger.kernel.org>,
Luca Coelho <luciano.coelho@intel.com>,
intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
"David S. Miller" <davem@davemloft.net>,
Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [Intel-wired-lan] [PATCH v1 1/4] igb: Remove unnecessary include of <linux/pci-aspm.h>
Date: Wed, 25 Jul 2018 14:12:08 -0700 [thread overview]
Message-ID: <CAKgT0UewV82FKVMkW975+upccaRJF4i6oQYzNh5jC02wcGmhXQ@mail.gmail.com> (raw)
In-Reply-To: <153254834342.92573.16877025672192312745.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Wed, Jul 25, 2018 at 12:52 PM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> The igb driver doesn't need anything provided by pci-aspm.h, so remove
> the unnecessary include of it.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Looks good to me.
Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index f707709969ac..c77fda05f683 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -22,7 +22,6 @@
> #include <linux/if.h>
> #include <linux/if_vlan.h>
> #include <linux/pci.h>
> -#include <linux/pci-aspm.h>
> #include <linux/delay.h>
> #include <linux/interrupt.h>
> #include <linux/ip.h>
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2018-07-25 21:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 19:52 [PATCH v1 0/4] PCI: Remove unnecessary includes of <linux/pci-aspm.h> Bjorn Helgaas
2018-07-25 19:52 ` [PATCH v1 1/4] igb: Remove unnecessary include " Bjorn Helgaas
2018-07-25 21:12 ` Alexander Duyck [this message]
2018-07-25 21:52 ` Jeff Kirsher
2018-07-25 19:52 ` [PATCH v1 2/4] ath9k: " Bjorn Helgaas
2018-07-26 6:07 ` Kalle Valo
2018-07-25 19:52 ` [PATCH v1 3/4] iwlwifi: " Bjorn Helgaas
2018-07-25 20:59 ` Luciano Coelho
2018-07-25 19:52 ` [PATCH v1 4/4] PCI: " Bjorn Helgaas
2018-07-25 20:33 ` [PATCH v1 0/4] PCI: Remove unnecessary includes " Sinan Kaya
2018-07-25 20:59 ` Bjorn Helgaas
2018-07-27 22:18 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKgT0UewV82FKVMkW975+upccaRJF4i6oQYzNh5jC02wcGmhXQ@mail.gmail.com \
--to=alexander.duyck@gmail.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=helgaas@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).