From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932779AbcLGUqy (ORCPT ); Wed, 7 Dec 2016 15:46:54 -0500 Received: from mail-ua0-f180.google.com ([209.85.217.180]:33925 "EHLO mail-ua0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753554AbcLGUqw (ORCPT ); Wed, 7 Dec 2016 15:46:52 -0500 MIME-Version: 1.0 In-Reply-To: <20161207111424.GA5507@elgon.mountain> References: <20161207111424.GA5507@elgon.mountain> From: Iyappan Subramanian Date: Wed, 7 Dec 2016 12:46:51 -0800 Message-ID: Subject: Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool() To: Dan Carpenter Cc: Keyur Chudgar , netdev , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 7, 2016 at 3:14 AM, Dan Carpenter wrote: > We never set "slots" in this function. > > Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame") > Signed-off-by: Dan Carpenter > --- > I copied how slots gets set in xgene_enet_rx_frame(). Static analysis. > Not tested. > > diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > index 6c7eea8b36af..884a334e82d0 100644 > --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > @@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool, > return; > > dev = ndev_to_dev(buf_pool->ndev); > + slots = buf_pool->slots - 1; > head = buf_pool->head; > > for (i = 0; i < 4; i++) { Thanks. Acked-by: Iyappan Subramanian