From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753623AbcLHSoj (ORCPT ); Thu, 8 Dec 2016 13:44:39 -0500 Received: from mail-ua0-f178.google.com ([209.85.217.178]:36646 "EHLO mail-ua0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752342AbcLHSoh (ORCPT ); Thu, 8 Dec 2016 13:44:37 -0500 MIME-Version: 1.0 In-Reply-To: <20161208111754.9711-1-colin.king@canonical.com> References: <20161208111754.9711-1-colin.king@canonical.com> From: Iyappan Subramanian Date: Thu, 8 Dec 2016 10:44:31 -0800 Message-ID: Subject: Re: [PATCH] drivers: net: xgene: initialize slots To: Colin King Cc: Keyur Chudgar , netdev , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 8, 2016 at 3:17 AM, Colin King wrote: > From: Colin Ian King > > static analysis using cppcheck detected that slots was uninitialized. > Fix this by initializing it to buf_pool->slots - 1 > > Found using static analysis with CoverityScan, CID #1387620 > > Fixes: a9380b0f7be818 ("drivers: net: xgene: Add support for Jumbo frame") > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > index 6c7eea8..899163c 100644 > --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > @@ -636,6 +636,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool, > > dev = ndev_to_dev(buf_pool->ndev); > head = buf_pool->head; > + slots = buf_pool->slots - 1; > > for (i = 0; i < 4; i++) { > frag_size = xgene_enet_get_data_len(le64_to_cpu(desc[i ^ 1])); Thanks, Colin. Dan Carpenter posted the fix already and got accepted. http://marc.info/?l=linux-netdev&m=148110980224343&w=2 > -- > 2.10.2 >