From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756663Ab2JCWP4 (ORCPT ); Wed, 3 Oct 2012 18:15:56 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:57438 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754416Ab2JCWPy (ORCPT ); Wed, 3 Oct 2012 18:15:54 -0400 MIME-Version: 1.0 In-Reply-To: References: <1340285798-8322-1-git-send-email-mchehab@redhat.com> <4FE37194.30407@redhat.com> <4FE8B8BC.3020702@iki.fi> <4FE8C4C4.1050901@redhat.com> <4FE8CED5.104@redhat.com> <20120625223306.GA2764@kroah.com> <4FE9169D.5020300@redhat.com> <20121002100319.59146693@redhat.com> From: Lucas De Marchi Date: Wed, 3 Oct 2012 19:15:31 -0300 Message-ID: Subject: Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait() To: Linus Torvalds Cc: Ivan Kalvachev , Mauro Carvalho Chehab , Lennart Poettering , Greg Kroah-Hartman , Linux Kernel Mailing List , Kay Sievers , Linux Media Mailing List , Michael Krufky Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 2, 2012 at 7:37 PM, Linus Torvalds wrote: > On Tue, Oct 2, 2012 at 2:03 PM, Ivan Kalvachev wrote: >> >> I'm not kernel developer and probably my opinion would be a little >> naive, but here it is. >> >> Please, make the kernel load firmware from the filesystem on its own. > > We probably should do that, not just for firmware, but for modules > too. It would also simplify the whole "built-in firmware" thing > > Afaik, the only thing udev really does is to lok in > /lib/firmware/updates and /lib/firmware for the file, load it, and > pass it back to the kernel. We could make the kernel try to do it > manually first, and only fall back to udev if that fails. > > Afaik, nobody ever does anything else anyway. > > I'd prefer to not have to do that, but if the udev code is buggy or > the maintainership is flaky, I guess we don't really have much choice. > > Doing the same thing for module loading is probably a good idea too. humn... I don't think so. It would work perfectly well for firmware, but for modules there are more things involved like fulfilling dependencies, soft-dependencies, aliases and the like. It would create several regressions. > There were already people (from the google/Android camp) who wanted to > do module loading based on filename rather than the buffer passed to > it, because they have a "I trust this filesystem" model. They wanted to pass a fd instead of a buffer. That is being done in the new finit_module syscall being discussed: http://www.gossamer-threads.com/lists/linux/kernel/1592271?do=post_view_flat Lucas De Marchi