linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: Alistair Francis <alistair@alistair23.me>
Cc: lgirdwood@gmail.com, Mark Brown <broonie@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time
Date: Thu, 29 Jul 2021 21:20:14 +1000	[thread overview]
Message-ID: <CAKmqyKP8HKERLS3ckOA3wwpiv6J4tdFXn8-d6wXxDXDGn5iN=w@mail.gmail.com> (raw)
In-Reply-To: <20210706114120.197-1-alistair@alistair23.me>

On Tue, Jul 6, 2021 at 9:41 PM Alistair Francis <alistair@alistair23.me> wrote:
>
> From testing on hardware the poll_enable_time isn't required and
> sometimes causes the driver probe to fail so let's remove it.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>

Ping

AlistaIr

> ---
>  drivers/regulator/sy7636a-regulator.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
> index e021ae08cbaa..c3b34cac8c7f 100644
> --- a/drivers/regulator/sy7636a-regulator.c
> +++ b/drivers/regulator/sy7636a-regulator.c
> @@ -13,8 +13,6 @@
>  #include <linux/gpio/consumer.h>
>  #include <linux/mfd/sy7636a.h>
>
> -#define SY7636A_POLL_ENABLED_TIME 500
> -
>  static int sy7636a_get_vcom_voltage_op(struct regulator_dev *rdev)
>  {
>         int ret;
> @@ -61,7 +59,6 @@ static const struct regulator_desc desc = {
>         .owner = THIS_MODULE,
>         .enable_reg = SY7636A_REG_OPERATION_MODE_CRL,
>         .enable_mask = SY7636A_OPERATION_MODE_CRL_ONOFF,
> -       .poll_enabled_time = SY7636A_POLL_ENABLED_TIME,
>         .regulators_node = of_match_ptr("regulators"),
>         .of_match = of_match_ptr("vcom"),
>  };
> --
> 2.31.1
>

  parent reply	other threads:[~2021-07-29 11:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 11:41 [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time Alistair Francis
2021-07-06 11:41 ` [PATCH 2/2] regulator: sy7636a: Use the parent driver data Alistair Francis
2021-07-29 11:20 ` Alistair Francis [this message]
2021-07-29 11:22   ` [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time Mark Brown
2021-07-30  6:11     ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKmqyKP8HKERLS3ckOA3wwpiv6J4tdFXn8-d6wXxDXDGn5iN=w@mail.gmail.com' \
    --to=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).