linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Vinod Koul <vkoul@infradead.org>
Cc: Per Forlin <per.forlin@linaro.org>,
	linux-kernel@vger.kernel.org,
	Rabin Vincent <rabin.vincent@stericsson.com>
Subject: Re: [PATCH 2/2] dmaengine: remove ste_dma40 from issue_pending TODO
Date: Thu, 7 Jul 2011 16:27:47 +0200	[thread overview]
Message-ID: <CAKnu2MoqGjgvVhSRQz_+bP=ErhaXp5+Rn0N+ui7F7SFmw=Q7vQ@mail.gmail.com> (raw)
In-Reply-To: <1310004032.20150.14.camel@psiaudioba-mobl1>

2011/7/7 Vinod Koul <vkoul@infradead.org>:
> On Sun, 2011-06-26 at 23:29 +0200, Per Forlin wrote:
>> ste_dma40 now implements issue_pending according to documentation.
>> Submit adds descriptos to a pending queue with are flushed down to the DMAC
>> at issue_pending.
>>
>> Signed-off-by: Per Forlin <per.forlin@linaro.org>
> How about the client driver which are currently using this driver, wont
> they break as they would be calling submit and not issue_pending...?

They all call both, so it works fine. First submit() then issue_pending()
in sucession.

In-tree drivers:
drivers/tty/serial/amba-pl011.c
drivers/mmc/host/mmci.c
drivers/spi/spi-pl022.c

So:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thanks,
Linus Walleij

  reply	other threads:[~2011-07-07 14:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-26 21:29 [PATCH 0/2] dmaengine/ste_dma40: Fix implementation of issue_pending Per Forlin
2011-06-26 21:29 ` [PATCH 1/2] dmaengine/ste_dma40: add a separate queue for pending requests Per Forlin
2011-06-26 21:29 ` [PATCH 2/2] dmaengine: remove ste_dma40 from issue_pending TODO Per Forlin
2011-07-07  2:00   ` Vinod Koul
2011-07-07 14:27     ` Linus Walleij [this message]
2011-07-13 22:32 ` [PATCH 0/2] dmaengine/ste_dma40: Fix implementation of issue_pending Koul, Vinod

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKnu2MoqGjgvVhSRQz_+bP=ErhaXp5+Rn0N+ui7F7SFmw=Q7vQ@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=per.forlin@linaro.org \
    --cc=rabin.vincent@stericsson.com \
    --cc=vkoul@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).