From: Rami Rosen <roszenrami@gmail.com>
To: Parav Pandit <pandit.parav@gmail.com>
Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-rdma@vger.kernel.org, tj@kernel.org,
Li Zefan <lizefan@huawei.com>,
hannes@cmpxchg.org, dledford@redhat.com, liranl@mellanox.com,
sean.hefty@intel.com, jgunthorpe@obsidianresearch.com,
haggaie@mellanox.com, corbet@lwn.net, james.l.morris@oracle.com,
serge@hallyn.com, Or Gerlitz <ogerlitz@mellanox.com>,
matanb@mellanox.com, Andrew Morton <akpm@linux-foundation.org>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCHv11 3/3] rdmacg: Added documentation for rdmacg
Date: Thu, 25 Aug 2016 01:55:37 +0300 [thread overview]
Message-ID: <CAKoUArnZvsost5pgysC9DL1_msBta0nmkXTjnk+0KxgwJAoR=Q@mail.gmail.com> (raw)
In-Reply-To: <1471869231-15576-4-git-send-email-pandit.parav@gmail.com>
Hi,
> +Whenever RDMA resource charing occurs, owner rdma cgroup is returned to
Should be: charging instead of charing
> +(b) Query resource limit:
> +cat /sys/fs/cgroup/rdma/2/rdma.max
> +#Output:
> +mlx4_0 uctx=max pd=max ah=2 mr=100 mw=max cq=max srq=max qp=10 flow=max
> +ocrdma1 uctx=1 pd=5 ah=1 mr=10 cq=10 srq=max qp=20 flow=max flow=max
Is this really so: double"flow=max" at the end of the ocrdma1 line?
(flow=max flow=max)
> +5-4. RDMA
> +
> +The "rdma" controller regulates the distribution and accounting of
> +of RDMA resources.
"of of" should be only a single "of"
> + mlx4_1 uctx=1 ah=0 pd=1 cq=4 qp=4 mr=100 srq=0 flow=10
> + ocrdma1 uctx=2 pd=2 ah=2 mr=20 mw=max cq=1 srq=1 qp=10 flow=10
Seems to be inconsistency here: in the first line you have qp=4
*before* srq=0, but in the second line you have qp=10 *after* srq=1.
Keep on the good work!
Regards,
Rami Rosen
next prev parent reply other threads:[~2016-08-24 22:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 12:33 [PATCHv11 0/3] rdmacg: IB/core: rdma controller support Parav Pandit
2016-08-22 12:33 ` [PATCHv11 1/3] rdmacg: Added rdma cgroup controller Parav Pandit
2016-08-22 12:33 ` [PATCHv11 2/3] IB/core: added support to use " Parav Pandit
2016-08-22 12:33 ` [PATCHv11 3/3] rdmacg: Added documentation for rdmacg Parav Pandit
2016-08-24 21:18 ` Tejun Heo
2016-08-24 22:55 ` Rami Rosen [this message]
2016-08-25 7:58 ` Parav Pandit
2016-08-24 21:17 ` [PATCHv11 0/3] rdmacg: IB/core: rdma controller support Tejun Heo
2016-08-25 7:32 ` Christoph Hellwig
2016-08-25 8:00 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKoUArnZvsost5pgysC9DL1_msBta0nmkXTjnk+0KxgwJAoR=Q@mail.gmail.com' \
--to=roszenrami@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dledford@redhat.com \
--cc=haggaie@mellanox.com \
--cc=hannes@cmpxchg.org \
--cc=james.l.morris@oracle.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=liranl@mellanox.com \
--cc=lizefan@huawei.com \
--cc=matanb@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=pandit.parav@gmail.com \
--cc=sean.hefty@intel.com \
--cc=serge@hallyn.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).