From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753106Ab2KVSbs (ORCPT ); Thu, 22 Nov 2012 13:31:48 -0500 Received: from mail-ia0-f174.google.com ([209.85.210.174]:36068 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753074Ab2KVSbq (ORCPT ); Thu, 22 Nov 2012 13:31:46 -0500 MIME-Version: 1.0 In-Reply-To: <20121122112451.GE4328@gmail.com> References: <20121122112451.GE4328@gmail.com> Date: Fri, 23 Nov 2012 00:01:45 +0530 Message-ID: Subject: Re: [PATCH V2 2/2] mfd: stmpe: Extend DT support in stmpe driver From: Viresh Kumar To: Lee Jones Cc: sameo@linux.intel.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com, Vipul Kumar Samar Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22 November 2012 16:54, Lee Jones wrote: >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt b/Documentation/devicetree/bindings/mfd/stmpe.txt >> +Optional properties: >> +- irq-trigger: IRQ trigger to use for the interrupt to the host >> +- irq-invert-polarity: bool, IRQ line is connected with reversed polarity > > Are these new? > > When adding new bindings, ask yourself: I was trying to get information of these two bindings from other sources, but couldn't find. The only other place can be the interrupts field, right? Because interrupts field depends on the interrupt controller, which can be a wide variety of controllers in our case, we can't use that. Also, the cells of interrupts field will have something that is required to be programmed in the interrupt controller and not in the user of IC. But here we are talking about programming stmpe and so these bindings are very much required in stmpe only. Comments?? -- viresh