From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755539Ab3HLF0Z (ORCPT ); Mon, 12 Aug 2013 01:26:25 -0400 Received: from mail-oa0-f47.google.com ([209.85.219.47]:47613 "EHLO mail-oa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755421Ab3HLF0V (ORCPT ); Mon, 12 Aug 2013 01:26:21 -0400 MIME-Version: 1.0 In-Reply-To: <1376239917-15594-13-git-send-email-Julia.Lawall@lip6.fr> References: <1376239917-15594-1-git-send-email-Julia.Lawall@lip6.fr> <1376239917-15594-13-git-send-email-Julia.Lawall@lip6.fr> Date: Mon, 12 Aug 2013 10:56:21 +0530 Message-ID: Subject: Re: [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argument From: Viresh Kumar To: Julia Lawall Cc: "Rafael J. Wysocki" , kernel-janitors@vger.kernel.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11 August 2013 22:21, Julia Lawall wrote: > From: Julia Lawall > > Replace ARRAY_AND_SIZE(e) in function argument position to avoid hiding the > arity of the called function. Makes sense. > The semantic match that makes this change is as follows: > (http://coccinelle.lip6.fr/) What is this doing here? > // > @@ > expression e,f; > @@ > > f(..., > - ARRAY_AND_SIZE(e) > + e,ARRAY_SIZE(e) > ,...) > // > > Signed-off-by: Julia Lawall > > --- > Not compiled. > > drivers/cpufreq/pxa3xx-cpufreq.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Acked-by: Viresh Kumar