From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752889AbaEGGEe (ORCPT ); Wed, 7 May 2014 02:04:34 -0400 Received: from mail-oa0-f43.google.com ([209.85.219.43]:35921 "EHLO mail-oa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751399AbaEGGEc (ORCPT ); Wed, 7 May 2014 02:04:32 -0400 MIME-Version: 1.0 In-Reply-To: References: <000001cf643d$69e5e350$3db1a9f0$@samsung.com> <003901cf6664$e4e8d2a0$aeba77e0$@samsung.com> <5367946F.1030407@ti.com> <003e01cf6984$fb950280$f2bf0780$@samsung.com> Date: Wed, 7 May 2014 11:34:32 +0530 Message-ID: Subject: Re: [PATCH 1/3] PM / OPP: Add support for descending order for cpufreq table From: Viresh Kumar To: Nishanth Menon Cc: Jonghwan Choi , Linux PM list , open list , "Rafael J. Wysocki" , Len Brown , Amit Daniel Kachhap Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7 May 2014 06:30, Nishanth Menon wrote: > So, we could do [2] as default as well, if it is determined to impact > no one else making any form of assumptions on table ordering - but it > might be preferable for drivers not to depend on framework ordering of > data as things could change in the future. Exactly and that's what we discussed earlier. I don't want to change the default behavior at all, as somebody may request the ascending order tomorrow :) @Jonghwan: Please consider doing this: - Don't play with the order of frequencies in table. - Instead initialize .driver_data filed with values that you need to write in the registers for all frequencies. i.e. 0 for highest frequency and FREQ_COUNT-1 for lowest one.