From: Viresh Kumar <viresh.kumar@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/6] dma: coh901318_lli: avoid unbalanced locking
Date: Tue, 12 Feb 2013 21:27:59 +0530 [thread overview]
Message-ID: <CAKohpok8K_GTTO1mT_1yF39gHZKWKwuH=tHBd1-K8ewDpFFUew@mail.gmail.com> (raw)
In-Reply-To: <1360666720-19006-4-git-send-email-andriy.shevchenko@linux.intel.com>
On 12 February 2013 16:28, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> I have not checked the code but there is a possibility that custom pool->lock
> is not needed at all due to dma_pool contains it's own lock.
Your viewpoint is fine, but we wanted the reason behind this patch
here. Please add appropriate stuff in only in logs.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/dma/coh901318_lli.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/coh901318_lli.c b/drivers/dma/coh901318_lli.c
> index 3e96610..702112d 100644
> --- a/drivers/dma/coh901318_lli.c
> +++ b/drivers/dma/coh901318_lli.c
> @@ -61,7 +61,7 @@ coh901318_lli_alloc(struct coh901318_pool *pool, unsigned int len)
> dma_addr_t phy;
>
> if (len == 0)
> - goto err;
> + return NULL;
>
> spin_lock(&pool->lock);
>
> --
> 1.7.10.4
>
next prev parent reply other threads:[~2013-02-12 15:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 10:58 [PATCH 0/6] dma: various fixes in different DMAC drivers Andy Shevchenko
2013-02-12 10:58 ` [PATCH 1/6] of: dma: protect list write operation by spin_lock Andy Shevchenko
2013-02-12 10:58 ` [PATCH 2/6] dmaengine.h: remove redundant else keyword Andy Shevchenko
2013-02-12 15:01 ` Viresh Kumar
2013-02-12 10:58 ` [PATCH 3/6] dma: coh901318_lli: avoid unbalanced locking Andy Shevchenko
2013-02-12 15:57 ` Viresh Kumar [this message]
2013-02-15 14:52 ` Linus Walleij
2013-02-15 14:56 ` Andy Shevchenko
2013-02-15 20:52 ` Linus Walleij
2013-02-12 10:58 ` [PATCH 4/6] dma: coh901318_lli: set residue only if dma is in progress Andy Shevchenko
2013-02-15 14:53 ` Linus Walleij
2013-02-12 10:58 ` [PATCH 5/6] edma: do not waste memory for dma_mask Andy Shevchenko
2013-02-12 10:58 ` [PATCH 6/6] dma: tegra20-apb-dma: remove unnecessary assignment Andy Shevchenko
2013-02-13 12:40 ` Laxman Dewangan
2013-02-12 16:02 ` [PATCH 0/6] dma: various fixes in different DMAC drivers Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKohpok8K_GTTO1mT_1yF39gHZKWKwuH=tHBd1-K8ewDpFFUew@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).