From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752640Ab3ABFo0 (ORCPT ); Wed, 2 Jan 2013 00:44:26 -0500 Received: from mail-oa0-f53.google.com ([209.85.219.53]:56469 "EHLO mail-oa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752615Ab3ABFoX (ORCPT ); Wed, 2 Jan 2013 00:44:23 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 2 Jan 2013 11:14:23 +0530 Message-ID: Subject: Re: [PATCH] sched/fair: Set se->vruntime directly in place_entity() From: Viresh Kumar To: mingo@redhat.com, peterz@infradead.org Cc: linaro-dev@lists.linaro.org, patches@linaro.org, linux-kernel@vger.kernel.org, Viresh Kumar Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8 November 2012 13:33, Viresh Kumar wrote: > We are first storing the new vruntime in a variable and then storing it in > se->vruntime. Simply update se->vruntime directly. > > Signed-off-by: Viresh Kumar > --- > kernel/sched/fair.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index a319d56c..820a2f1 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1454,9 +1454,7 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int initial) > } > > /* ensure we never gain time by being placed backwards. */ > - vruntime = max_vruntime(se->vruntime, vruntime); > - > - se->vruntime = vruntime; > + se->vruntime = max_vruntime(se->vruntime, vruntime); > } Ping!!