From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754401Ab3BVCIS (ORCPT ); Thu, 21 Feb 2013 21:08:18 -0500 Received: from mail-ob0-f169.google.com ([209.85.214.169]:45245 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753936Ab3BVCIN (ORCPT ); Thu, 21 Feb 2013 21:08:13 -0500 MIME-Version: 1.0 In-Reply-To: <3793606.bilcxohA80@vostro.rjw.lan> References: <3793606.bilcxohA80@vostro.rjw.lan> Date: Fri, 22 Feb 2013 07:38:12 +0530 Message-ID: Subject: Re: [PATCH V2 1/4] cpufreq: Add per policy governor-init/exit infrastructure From: Viresh Kumar To: "Rafael J. Wysocki" Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, linaro-dev@lists.linaro.org, francescolavra.fl@gmail.com, toddpoynor@google.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22 February 2013 05:05, Rafael J. Wysocki wrote: > On Monday, February 11, 2013 01:20:00 PM Viresh Kumar wrote: >> This patch is inclined towards providing this infrastructure. Because we are >> required to allocate governor's resources dynamically now, we must do it at >> policy creation and end. And so got CPUFREQ_GOV_POLICY_INIT/EXIT. > > Are those new events NOPs now? No. These are used atleast for ondemand & conservative. >> +#define CPUFREQ_GOV_POLICY_INIT 4 >> +#define CPUFREQ_GOV_POLICY_EXIT 4 > > Why don't you use different values here? > > If you need only one value, one #define should be sufficient. Naah, something happened... I got fixed this locally but couldn't get that into the commit somehow. EXIT should have 5 here.