From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D512C43382 for ; Thu, 27 Sep 2018 17:05:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4082921564 for ; Thu, 27 Sep 2018 17:05:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="Kit/tBWW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4082921564 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728725AbeI0XY7 (ORCPT ); Thu, 27 Sep 2018 19:24:59 -0400 Received: from mail-it1-f194.google.com ([209.85.166.194]:36415 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728062AbeI0XY7 (ORCPT ); Thu, 27 Sep 2018 19:24:59 -0400 Received: by mail-it1-f194.google.com with SMTP id c85-v6so8497914itd.1 for ; Thu, 27 Sep 2018 10:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AwEGUL1NA4kHX5XC94upxrAIeVzdtNSKcRKmm7WoCPU=; b=Kit/tBWWHysocmGe8gDCq/AFJeRpuAAq704hIJ0wB7OkluMUZ2AVjyCiavSn7CBup2 ZBazTKYSgdUIl3SWVnJBWrLi8aBgFOoFLkAcL5Vfff2XsoLIt5f5yeUIy2mVekCTQRDt eObLZUJrKucNQyTXIYSiDA4NEelDcTq7PzspI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AwEGUL1NA4kHX5XC94upxrAIeVzdtNSKcRKmm7WoCPU=; b=unC7mxtMxH+4Qlk96aJm9fN93l8UtNkJZhi3n901Ka3Xzkz8zE/MRrtC8ExmuVggrS bv6nKYjr1gM9jov1wq38gFSZvilaq/uvX5UaG8sRG4b4EumfSgbTZe2RU6tMR8bbD3rV koSy/ffLSSqX+pnQ2DbQiLTvorjH8RfPD6HfvQFsvlu/DAFY3rgKTdNflmENcECx7C3u nH4/ewy1PuFdU2O/nX3NlskcLDcKne122hJ2PTjgkeAEf1lztvpZVXGEa9twUj2nSzdG 6fKvaMjudarQ3zxwRQ6aI7bGUzAtdZnGQauNDXmdEKvLQWrOE0+5l1WvZNQhAcwel+Qu I03Q== X-Gm-Message-State: ABuFfogEr1vtBZ3SzLEBbSTzZdYDtIE7GrDUG7eN1pI8USR/cv3P/ZeU 9khELvITcGrvId+xEl21tei8hzGpmSzA/Wm+Bh/oeQ== X-Google-Smtp-Source: ACcGV62bw71shd+XScqvQU2Q0AOYxuHUynvVNR3VqvYDE6vlS00l2hR2z/l51FvC+ZrqXwAUcb1POXvQzGUxZflDr9E= X-Received: by 2002:a24:8309:: with SMTP id d9-v6mr9738918ite.123.1538067945425; Thu, 27 Sep 2018 10:05:45 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:2848:0:0:0:0:0 with HTTP; Thu, 27 Sep 2018 10:05:44 -0700 (PDT) In-Reply-To: <1538067309-5711-1-git-send-email-maksym.kokhan@globallogic.com> References: <1538067309-5711-1-git-send-email-maksym.kokhan@globallogic.com> From: Ard Biesheuvel Date: Thu, 27 Sep 2018 19:05:44 +0200 Message-ID: Subject: Re: [PATCH 0/8] add generic builtin command line To: Maksym Kokhan Cc: Andrew Morton , Rob Herring , Frank Rowand , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "the arch/x86 maintainers" , Russell King , Catalin Marinas , Will Deacon , Ralf Baechle , Paul Burton , James Hogan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Daniel Walker , Daniel Walker , Andrii Bordunov , Ruslan Bilovol , Linux Kernel Mailing List , Devicetree List , linux-efi , linux-mips , linuxppc-dev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27 September 2018 at 18:55, Maksym Kokhan wrote: > There were series of patches [1] for 4.3.0-rc3, that allowed > architectures to use a generic builtin command line. I have rebased > these patches on kernel 4.19.0-rc4. > Could you please elaborate on the purpose of this series? Is it simply to align between architectures? Does it solve an actual problem? > Things, modified in comparison with original patches: > * There was some bug for mips, in the case when CONFIG_CMDLINE_PREPEND > and CONFIG_CMDLINE_APPEND are empty and CMDLINE_OVERRIDE is not set, > command line from bootloader was ignored, so I fixed it, modifying > patch "add generic builtin command line". > > * Implemented new patch to resolve conflict with new kernel, which > modify EFI stub code. Unfortunately, I don't have capability to test > this modification on real arm board with EFI. > > * Removed new realisation of mips builtin command line, which was > created after 4.3.0-rc3. > > * Kernel 4.3.0-rc3 with original patches could not be compiled for > powerpc due to prom_init.c checking by prom_init_check.sh. So I added > strlcat (which is used by cmdline_add_builtin macro) to > prom_init_check.sh whitelist. > > Patches have been tested in QEMU for x86, arm (little-endian), arm64 > (little-endian), mips (little-endian, 32-bit) and powerpc > (big-endian, 64-bit), everything works perfectly. Also it was tested > on linux-next (next-20180924 tag) for all listed above architectures. > > [1] : https://lore.kernel.org/patchwork/patch/604992/ > > Daniel Walker (7): > add generic builtin command line > drivers: of: ifdef out cmdline section > x86: convert to generic builtin command line > arm: convert to generic builtin command line > arm64: convert to generic builtin command line > mips: convert to generic builtin command line > powerpc: convert to generic builtin command line > > Maksym Kokhan (1): > efi: modify EFI stub code for arm/arm64 > > arch/arm/Kconfig | 38 +----------------- > arch/arm/kernel/atags_parse.c | 14 ++----- > arch/arm/kernel/devtree.c | 2 + > arch/arm64/Kconfig | 17 +------- > arch/arm64/kernel/setup.c | 3 ++ > arch/mips/Kconfig | 24 +---------- > arch/mips/Kconfig.debug | 47 ---------------------- > arch/mips/kernel/setup.c | 41 ++----------------- > arch/powerpc/Kconfig | 23 +---------- > arch/powerpc/kernel/prom.c | 4 ++ > arch/powerpc/kernel/prom_init.c | 8 ++-- > arch/powerpc/kernel/prom_init_check.sh | 2 +- > arch/x86/Kconfig | 44 +-------------------- > arch/x86/kernel/setup.c | 19 ++------- > drivers/firmware/efi/libstub/arm-stub.c | 10 ++--- > drivers/of/fdt.c | 2 +- > include/linux/cmdline.h | 70 +++++++++++++++++++++++++++++++++ > init/Kconfig | 68 ++++++++++++++++++++++++++++++++ > 18 files changed, 173 insertions(+), 263 deletions(-) > create mode 100644 include/linux/cmdline.h > > -- > 2.7.4 >