From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7796CA9ECE for ; Thu, 31 Oct 2019 13:48:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE9082086D for ; Thu, 31 Oct 2019 13:48:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nl4MS2a1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727757AbfJaNsH (ORCPT ); Thu, 31 Oct 2019 09:48:07 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:34855 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727576AbfJaNsH (ORCPT ); Thu, 31 Oct 2019 09:48:07 -0400 Received: by mail-wr1-f67.google.com with SMTP id l10so6337485wrb.2 for ; Thu, 31 Oct 2019 06:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QksVvRkxEC/Fbmw0ixK2EWKntOYb1CjKsU27i/CLKQ8=; b=nl4MS2a1kfU8kAKWpuvJLyCivDaGmr9zyq1KInHFqBvTA1HRD4TqoMNN40KezpcHtr ERoMUn54CqTNLROl+2LJoGvngj+2cbuGQ21Yi8clJubBSY4GQzbRFlu/GK/JLTazCoAQ AsZfZRPgEfRlSbsLidVg04cqTRWRmDAAfYa4nxOTwGd/76+br42fNuhQcl0JbITdzHKo mWip9oVWlLU8LheD6xU33kv64UeSrVHOdGvTuoJ+Hg1kqlLFx3b/bPB/DcQ7glNw3np2 HZYBO7/QDDqTR/KygjoruiafycjN01DG9jisud/hlZsdmQ9WuTxiXSAfsU7vrX8qwRAy FQwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QksVvRkxEC/Fbmw0ixK2EWKntOYb1CjKsU27i/CLKQ8=; b=IKexsHAacMANgpCaDPAEy2FieFxnnkvjiuqChG9OnGtbvMXZW7IYucpzlqnEV3g5yD NzZ1bCtjPcAAWvwHI+w2z+jct1cooOfe52y6EGKX8N2HlyjikMqjnZIzwso5UodIGfrR t9Pk6lSYf2sN61049phHSMX2kKBXRaW7XUXHIwXi0lE6Qwm6+zrf4RhsqyKWzWEPDKTZ XP6gtO88AZtPOgoX32pjlqluZvmg6MZXemWQps6EgLa3QVfsyS4kewyh0qUeKybZ1kNZ clug37xx2BLyrFosFEhzNXfR+7WF7zHULm4Hb9mQiVZ/otgjhkePjqRftTbulbl6in3g huoQ== X-Gm-Message-State: APjAAAW8EI3x+PIn899dKxhFCeW6sci9KAui9iivkXxHX40YIyISTBmU uormESBKHyPHKBCkJ6JH7v3lqsivton7oFzZyIAa7Q== X-Google-Smtp-Source: APXvYqw7fXK428FamCSNbDLwZ5YfXyMWJpGq2TSe1+1tdihbiys5tLPxlhHWAoeYJsedRdsuhWgMsQnEhMJb+dyFN84= X-Received: by 2002:adf:8289:: with SMTP id 9mr6112282wrc.0.1572529685061; Thu, 31 Oct 2019 06:48:05 -0700 (PDT) MIME-Version: 1.0 References: <20191029173755.27149-1-ardb@kernel.org> <20191029173755.27149-4-ardb@kernel.org> <20191031084126.GB107774@gmail.com> In-Reply-To: <20191031084126.GB107774@gmail.com> From: Ard Biesheuvel Date: Thu, 31 Oct 2019 14:47:53 +0100 Message-ID: Subject: Re: [PATCH v2 3/6] efi/random: treat EFI_RNG_PROTOCOL output as bootloader randomness To: Ingo Molnar Cc: Bhupesh Sharma , Ard Biesheuvel , linux-efi , Thomas Gleixner , Dominik Brodowski , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 31 Oct 2019 at 09:41, Ingo Molnar wrote: > > > * Ard Biesheuvel wrote: > > > On Tue, 29 Oct 2019 at 20:14, Bhupesh Sharma wrote: > > > > > > Hi Ard, > > > > > > On Tue, Oct 29, 2019 at 11:10 PM Ard Biesheuvel wrote: > > > > > > > > From: Dominik Brodowski > > > > > > > > Commit 428826f5358c ("fdt: add support for rng-seed") introduced > > > > add_bootloader_randomness(), permitting randomness provided by the > > > > bootloader or firmware to be credited as entropy. However, the fact > > > > that the UEFI support code was already wired into the RNG subsystem > > > > via a call to add_device_randomness() was overlooked, and so it was > > > > not converted at the same time. > > > > > > > > Note that this UEFI (v2.4 or newer) feature is currently only > > > > implemented for EFI stub booting on ARM, and further note that > > > > CONFIG_RANDOM_TRUST_BOOTLOADER must be enabled, and this should be > > > > done only if there indeed is sufficient trust in the bootloader > > > > _and_ its source of randomness. > > > > > > > > Signed-off-by: Dominik Brodowski > > > > [ardb: update commit log] > > > > Signed-off-by: Ard Biesheuvel > > > > > > Seems my Tested-by was dropped which I provide for the RFC version of > > > this patch. > > > See > > > for details. > > > > > > I can provide a similar Tested-by for this version as well. > > > > > > > Thanks Bhupesh > > I've added Bhupesh's Tested-by to the commit - no need to resend. > > I've picked up all 6 EFI fixes, will push them out after a bit of testing > - sorry about the delay! > No worries, thanks for picking them up.