From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F1DC04AB5 for ; Thu, 6 Jun 2019 06:43:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6889C20673 for ; Thu, 6 Jun 2019 06:43:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y2RWECTN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726671AbfFFGnB (ORCPT ); Thu, 6 Jun 2019 02:43:01 -0400 Received: from mail-it1-f195.google.com ([209.85.166.195]:36148 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725769AbfFFGnB (ORCPT ); Thu, 6 Jun 2019 02:43:01 -0400 Received: by mail-it1-f195.google.com with SMTP id r135so1460069ith.1 for ; Wed, 05 Jun 2019 23:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fAmwhrw558wPfYHxjN+8HYUKXtrdMSbO0EAw2Cpf0/Y=; b=Y2RWECTNdkv+bdqw56t/foazdmSKW9C7UxFQGxElH4MDqQBFAo0IvyTHLt9KdqZg1X Q/QIt1+bxXD+WNT5G3hLKNVmPxusK2ThjQQJ9BxejHuN0tvOTSu3/UHYf/4JfxMpEKME 65oaStHZ6AKM/54UQy6jDVNNsG5GKYIwb6vbkowvq7TtLf6k+ib4vBSoHlXOMC8U7gPR DqAoyLvIebgUjw1Xu5iVpyp7QMPNRJvk2iJID9gxT1F+hKuCZPvz+ncNiAQWwmADxY7Z ACC5BZ9iMQD148kDb59+r9Rc23mHRrpir2NUmfLhL6EY4cD9GExP80lO3aVxaKDjA37A iAgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fAmwhrw558wPfYHxjN+8HYUKXtrdMSbO0EAw2Cpf0/Y=; b=hQe6Y2GmgmDPmZLV8Xwo6DFmbgk3CKPKj+oqY60a6ce+M/qPHJJlzDq/lmj67vAgYU +rHZvVmBYEcTHDFCeKUevrhziw3K3u8+yn3EI0EIMl/0rGNYtRdis2zl/YcsBgikbG0d Jvofj2W6gcXD2U7iR1BVqbWiGFkKQj0vdxoYvqeT6MPbHC7TbUR9k3KWNZU53cXLIttU jaFHkIciCPFjRpqAu/aqsbFc7S+/HewvZjiq81NDrwd26q+L5AchbocYaD3tHjvAbfCD 41qek5F3RVKeLM39oUT447NpcXAsv9cr7ayGX/SUP2QpC12vm+uPMP8cxhd+4w0VTj3u XR0Q== X-Gm-Message-State: APjAAAWqQ8L+eRJqoNK7F9eOLOra/Eq82DQ3x0kvNVO8SJ9bQoJBE3OF yDUZv/kTrMSONl5a8o/AH0OiWamyeWaO9L20NbYggA== X-Google-Smtp-Source: APXvYqz86e78yfLOLdlh1MV/pnoTIXiTUppGfvfKOxeaUm9ISXwFavbNpBwij9JySv01+d6Iq8N/vHDVsb8dioEsUfY= X-Received: by 2002:a02:ce37:: with SMTP id v23mr29258959jar.2.1559803380499; Wed, 05 Jun 2019 23:43:00 -0700 (PDT) MIME-Version: 1.0 References: <20190529202728.GA35103@gmail.com> <20190530133427.qrwjzctac2x6nsby@gondor.apana.org.au> <20190530142734.qlhgzeal22zxfhk5@gondor.apana.org.au> <20190606063724.n77z7gaf32tmyxng@gondor.apana.org.au> In-Reply-To: <20190606063724.n77z7gaf32tmyxng@gondor.apana.org.au> From: Ard Biesheuvel Date: Thu, 6 Jun 2019 08:42:46 +0200 Message-ID: Subject: Re: [PATCH] crypto: gcm - fix cacheline sharing To: Herbert Xu Cc: Iuliana Prodan , Eric Biggers , "David S. Miller" , Horia Geanta , Sascha Hauer , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Linux Kernel Mailing List , dl-linux-imx Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Jun 2019 at 08:37, Herbert Xu wrote: > > On Thu, May 30, 2019 at 04:31:09PM +0200, Ard Biesheuvel wrote: > > > > This might work: > > > > diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c > > index c0ece44f303b..3d313d2a279a 100644 > > --- a/drivers/crypto/caam/caamalg.c > > +++ b/drivers/crypto/caam/caamalg.c > > @@ -1661,7 +1661,8 @@ static int aead_decrypt(struct aead_request *req) > > * allocate and map the skcipher extended descriptor for skcipher > > */ > > static struct skcipher_edesc *skcipher_edesc_alloc(struct > > skcipher_request *req, > > - int desc_bytes) > > + int desc_bytes, > > + u8 const *input_iv) > > { > > struct crypto_skcipher *skcipher = crypto_skcipher_reqtfm(req); > > struct caam_ctx *ctx = crypto_skcipher_ctx(skcipher); > > @@ -1745,7 +1746,7 @@ static struct skcipher_edesc > > *skcipher_edesc_alloc(struct skcipher_request *req, > > /* Make sure IV is located in a DMAable area */ > > if (ivsize) { > > iv = (u8 *)edesc->hw_desc + desc_bytes + sec4_sg_bytes; > > - memcpy(iv, req->iv, ivsize); > > + memcpy(iv, input_iv, ivsize); > > > > iv_dma = dma_map_single(jrdev, iv, ivsize, DMA_TO_DEVICE); > > if (dma_mapping_error(jrdev, iv_dma)) { > > Hi Ard: > > I presume you will be submitting this patch at some point? When > you do please base it on top of your other one which I'm about to > merge. > I'm not sure I follow. Do you want a better fix for the CBC output IV going forward? Or is this about other modes?