From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the arm64 tree
Date: Tue, 24 Jul 2018 11:30:23 +0200 [thread overview]
Message-ID: <CAKv+Gu8T9WJN6SNndcVNafaqCfNpEuSx5XRqdrM8DOjzfyZzqg@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a0bOYPtsCb8_etWtFCsnjB-xkMPFiy7iBubThi0b-LtVg@mail.gmail.com>
On 24 July 2018 at 10:12, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Jul 24, 2018 at 2:26 AM, AKASHI Takahiro
> <takahiro.akashi@linaro.org> wrote:
>> On Tue, Jul 24, 2018 at 09:05:45AM +1000, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the arm64 tree, today's linux-next build (x86_64
>>> allmodconfig) produced this warning:
>>
>> Where can I find this specific branch?
>>
>>> drivers/acpi/Kconfig:6:error: recursive dependency detected!
>>> drivers/acpi/Kconfig:6: symbol ACPI depends on EFI
>>
>> My patch created an additional dependency like:
>> menu ACPI
>> ...
>> depends on IA64 || X86 || (ARM64 && EFI)
>>
>>> arch/x86/Kconfig:1920: symbol EFI depends on ACPI
>>
>> So I don't understand why this change makes a warning on x86_64 build.
>> Is this a real recursive dependency?
>
> On x86, we have
>
> config EFI
> bool "EFI runtime service support"
> depends on ACPI
>
> Kconfig cannot know that CONFIG_ARM64 is never set on x86, while
> X86 is always set. So to Kconfig it it appears like a recursive
> dependency.
>
> The best workaround I can see is to have an intermediate symbol
> on ARM64 that is invisible to Kconfig on x86, like
>
> config ARCH_SUPPORTS_ACPI
> def_bool EFI
>
> and then have ACPI depend on that.
>
I suppose you mean
depends on IA64 || X86 || ARCH_SUPPORTS_ACPI
right?
Instead, perhaps we could have
config ARCH_SUPPORTS_ACPI
def_bool IA64 || X86
and make CONFIG_ACPI depend on that. Then, we can set it conditionally
in arch/arm64/Kconfig if CONFIG_EFI is enabled.
next prev parent reply other threads:[~2018-07-24 9:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 23:05 linux-next: build warning after merge of the arm64 tree Stephen Rothwell
2018-07-24 0:26 ` AKASHI Takahiro
2018-07-24 8:12 ` Arnd Bergmann
2018-07-24 9:30 ` Ard Biesheuvel [this message]
2022-03-09 11:34 Stephen Rothwell
2022-03-09 12:18 ` Will Deacon
2022-07-07 9:57 Stephen Rothwell
2022-07-07 10:28 ` Will Deacon
2023-06-13 6:23 Stephen Rothwell
2023-06-13 15:59 ` Catalin Marinas
2023-10-24 6:24 Stephen Rothwell
2023-10-24 9:55 ` Catalin Marinas
2023-10-24 13:42 ` Ard Biesheuvel
2023-10-24 16:14 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu8T9WJN6SNndcVNafaqCfNpEuSx5XRqdrM8DOjzfyZzqg@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).