From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: Allow user selection of ARM64_MODULE_PLTS
Date: Fri, 14 Jun 2019 09:02:49 +0200 [thread overview]
Message-ID: <CAKv+Gu8U1=Yxo7Mw6WsJbe82sRpjAq91HGW5XJi77ee+=BkGeA@mail.gmail.com> (raw)
In-Reply-To: <20190614025932.533-1-f.fainelli@gmail.com>
On Fri, 14 Jun 2019 at 04:59, Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> Make ARM64_MODULE_PLTS a selectable Kconfig symbol, since some people
> might have very big modules spilling out of the dedicated module area
> into vmalloc. Help text is copied from the ARM 32-bit counterpart.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm64/Kconfig | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 697ea0510729..36befe987b73 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1418,8 +1418,20 @@ config ARM64_SVE
> KVM in the same kernel image.
>
> config ARM64_MODULE_PLTS
> - bool
> + bool "Use PLTs to allow module memory to spill over into vmalloc area"
> select HAVE_MOD_ARCH_SPECIFIC
> + help
> + Allocate PLTs when loading modules so that jumps and calls whose
> + targets are too far away for their relative offsets to be encoded
> + in the instructions themselves can be bounced via veneers in the
> + module's PLT. This allows modules to be allocated in the generic
> + vmalloc area after the dedicated module memory area has been
> + exhausted. The modules will use slightly more memory, but after
> + rounding up to page size, the actual memory footprint is usually
> + the same.
> +
> + Disabling this is usually safe for small single-platform
> + configurations. If unsure, say y.
>
I don't mind adding this, but it makes sense to add an explanation why
KASLR enables this. E.g.,
"""
When running with address space randomization (KASLR), the module
region itself may be too far away for ordinary relative jumps and
calls, and so in that case, module PLTs are required and cannot be
disabled.
"""
> config ARM64_PSEUDO_NMI
> bool "Support for NMI-like interrupts"
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-06-14 7:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 2:59 [PATCH] arm64: Allow user selection of ARM64_MODULE_PLTS Florian Fainelli
2019-06-14 7:02 ` Ard Biesheuvel [this message]
2019-06-17 17:32 ` Will Deacon
2019-06-17 18:03 ` Florian Fainelli
2019-06-17 18:10 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu8U1=Yxo7Mw6WsJbe82sRpjAq91HGW5XJi77ee+=BkGeA@mail.gmail.com' \
--to=ard.biesheuvel@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-kernel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).