From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller
Date: Mon, 26 Feb 2018 17:16:22 +0000 [thread overview]
Message-ID: <CAKv+Gu8ZAt43km=mANa9Ehx1Evbj8cLB5vFsFwji9x6ARvD-sw@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vco1wUR7cUu-zuaP-TVMnm+m7X+CctnRC0cgvpuo5S2vg@mail.gmail.com>
On 26 February 2018 at 17:05, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Mon, Feb 26, 2018 at 4:58 PM, Ard Biesheuvel
> <ard.biesheuvel@linaro.org> wrote:
>> On 26 February 2018 at 11:35, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>>> On Mon, Feb 26, 2018 at 11:59 AM, Ard Biesheuvel
>>> <ard.biesheuvel@linaro.org> wrote:
>>>> On 23 February 2018 at 13:12, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>>>>> On Fri, Feb 23, 2018 at 2:40 PM, Ard Biesheuvel
>>>>> <ard.biesheuvel@linaro.org> wrote:
>
>>>>> Replace 'baudclk' with 'pclk' and p->uartclk with i2c->clkrate in
>>>>> above and you are almost done.
>
>>>> I don't think this is better.
>>>
>>> It's a pattern over ACPI vs. clk cases at least for now.
>>> But hold on. We have already an example of dealing with ACPI /
>>> non-ACPI cases for I2C controllers — i2c-designware-platdrv.c.
>>> Check how it's done there.
>>>
>>> I actually totally forgot about ACPI slaves described in the table. We
>>> need to take into account the ones with lowest bus speed.
>>>
>>
>> Wow, that code is absolutely terrible.
>
> To some degree I may say yes it is.
>
>> So even while _DSD device properties require vendor prefixes, which
>> are lacking in this case,
>
> What kind? clock-frequency? Does it require prefix?
>
What I remember from the _DSD discussions is that we should vendor
prefixes for per-device properties, and only use unprefixed names for
generic properties. However, looking more closely, I understand that
this undermines the idea of having parity between DT and ACPI, because
DT did not require vendor prefixes in the past (but it does now)
I guess 'clock-frequency' is one that would not require such a vendor prefix.
>> and the fact that the ACPI flavor of the
>> Designware I2C controller now provides two different ways to get the
>> timing parameters (using device properties or using SSCN/FMCN/etc ACPI
>> methods), you think this is a shining example of how this should be
>> implemented?
>
> No, those methods because of windows driver and existed ACPI tables at
> that time.
> You are not supposed to uglify your case.
>
OK, in that case, can you please spell out what you think is
mandatory? Because handwavy references to existing UART and I2C
drivers are not helping me here.
>> Also, I still think implementing a clock device using rate X just to
>> interrogate it for its rate (returning X) is absolutely pointless.
>
> OTOH the deviation in the driver is what I absolutely against of.
> Driver must not know the resource provider (ideally at all).
>
There is no 'resource provider'. There is only a single number, which
is the clock rate, and is only used to calculate some internal
dividers of the I2C IP block.
>> So what I can do is invent an ACPI method that returns the PCLK rate.
>> Would that work for you?
>
> Again, looking into existing examples (UART, I2C, etc) we better to
> create a generic helper in clock framework that would provide us a
> clock based on property value.
> But doing different paths for different resource providers is not what
> we are looking for.
>
> P.S. To move this somehow forward I may propose to submit an OF
> driver, and discuss ACPI part after.
>
Thanks, but that does not really work for me. What I can do is split
it into an initial DT only driver, and a followup ACPI patch.
Can you point me to an example of such a clock provider?
next prev parent reply other threads:[~2018-02-26 17:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 19:16 [PATCH v2 0/2]add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-02-22 19:16 ` [PATCH v2 1/2] dt-bindings: i2c: add binding for Socionext SynQuacer I2C Ard Biesheuvel
2018-02-22 19:16 ` [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-02-23 12:27 ` Andy Shevchenko
2018-02-23 12:40 ` Ard Biesheuvel
2018-02-23 13:12 ` Andy Shevchenko
2018-02-26 9:59 ` Ard Biesheuvel
2018-02-26 11:35 ` Andy Shevchenko
2018-02-26 14:58 ` Ard Biesheuvel
2018-02-26 17:05 ` Andy Shevchenko
2018-02-26 17:16 ` Ard Biesheuvel [this message]
2018-02-26 17:51 ` Ard Biesheuvel
2018-02-26 18:18 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu8ZAt43km=mANa9Ehx1Evbj8cLB5vFsFwji9x6ARvD-sw@mail.gmail.com' \
--to=ard.biesheuvel@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).