From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933660AbeBVSI3 (ORCPT ); Thu, 22 Feb 2018 13:08:29 -0500 Received: from mail-it0-f51.google.com ([209.85.214.51]:35733 "EHLO mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933504AbeBVSI2 (ORCPT ); Thu, 22 Feb 2018 13:08:28 -0500 X-Google-Smtp-Source: AG47ELt6gSd2BHroUwJu40+bAPjosQlilHi+OE8LFVsOM4P36bVQmc1CH6eONWi+J8xH+e38YKHgRVhPQ5BrUm9RVto= MIME-Version: 1.0 In-Reply-To: References: <3908561D78D1C84285E8C5FCA982C28F7B37F130@ORSMSX110.amr.corp.intel.com> <20180222014505.2l76ccrrs36y3b26@agluck-desk> <3908561D78D1C84285E8C5FCA982C28F7B37FE28@ORSMSX110.amr.corp.intel.com> <612E894E-62C8-4155-AED8-D53702EDC8DC@intel.com> <20180222171506.wwsichkiyc5f74pr@agluck-desk> <20180222175411.xzx2d2r2fahn7llo@agluck-desk> From: Ard Biesheuvel Date: Thu, 22 Feb 2018 18:08:26 +0000 Message-ID: Subject: Re: [PATCH v2] efivarfs: Limit the rate for non-root to read files To: Linus Torvalds Cc: "Luck, Tony" , Andi Kleen , Joe Konno , "linux-efi@vger.kernel.org" , Linux Kernel Mailing List , Jeremy Kerr , Matthew Garrett , Peter Jones , Andy Lutomirski , James Bottomley Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22 February 2018 at 18:07, Linus Torvalds wrote: > On Thu, Feb 22, 2018 at 9:54 AM, Luck, Tony wrote: >> With the new "while/nap" change there would still be one message >> per second, but the number of callbacks suppressed should be 1 >> (unless the user has many threads doing reads). >> >> Maybe it is good to know that an application is doing something >> stupid and we should drop that line from the patch and let the >> warnings flow? > > I think the "one message per second" is fine. > > Looks good. Do I get this through the EFI tree, or should I just take > it directly? > Please take it directly if everybody is happy with it. Acked-by: Ard Biesheuvel