From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-efi@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Hans de Goede <hdegoede@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] efi/x86: Clean up the eboot code a bit
Date: Mon, 14 May 2018 08:59:33 +0200 [thread overview]
Message-ID: <CAKv+Gu9gzHXNfHwZAoXfOX4F-UbsGjbjZce-iD00E-uqRrC88Q@mail.gmail.com> (raw)
In-Reply-To: <20180514065852.GE16596@gmail.com>
On 14 May 2018 at 08:58, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
>> On 14 May 2018 at 08:43, Ingo Molnar <mingo@kernel.org> wrote:
>> >
>> > So I looked at arch/x86/boot/compressed/eboot.c to improve a printk message and
>> > ended up with the cleanups below.
>> >
>> > Only build tested.
>> >
>> > Thanks,
>> >
>> > Ingo
>> >
>> > =================>
>> > Subject: efi/x86: Clean up the eboot code
>> > From: Ingo Molnar <mingo@kernel.org>
>> > Date: Mon May 14 08:33:40 CEST 2018
>> >
>> > Various small cleanups:
>> >
>> > - Standardize printk messages:
>> >
>> > 'alloc' => 'allocate'
>> > 'mem' => 'memory'
>> >
>> > also put variable names in printk messages between quotes.
>> >
>> > - Align mass-assignments vertically for better readability
>> >
>> > - Break multi-line function prototypes at the name where possible,
>> > not in the middle of the parameter list
>> >
>> > - Use a newline before return statements consistently.
>> >
>> > - Use curly braces in a balanced fashion.
>> >
>> > - Remove stray newlines.
>> >
>> > No change in functionality.
>> >
>> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
>> > Cc: Matt Fleming <matt@codeblueprint.co.uk>
>> > Cc: Peter Zijlstra <peterz@infradead.org>
>> > Cc: Thomas Gleixner <tglx@linutronix.de>
>> > Cc: linux-efi@vger.kernel.org
>> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
>>
>> Thanks Ingo
>>
>> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Thanks - mind picking it up into your tree? I only did minimal testing and don't
> want to interfere with your patch flow either.
>
Will do, thanks.
next prev parent reply other threads:[~2018-05-14 6:59 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 5:59 [GIT PULL 00/17] EFI updates for v4.18 Ard Biesheuvel
2018-05-04 5:59 ` [PATCH 01/17] x86/xen/efi: Initialize UEFI secure boot state during dom0 boot Ard Biesheuvel
2018-05-14 7:43 ` [tip:efi/core] " tip-bot for Daniel Kiper
2018-05-04 5:59 ` [PATCH 02/17] efi/cper: Remove the INDENT_SP silliness Ard Biesheuvel
2018-05-14 7:44 ` [tip:efi/core] " tip-bot for Borislav Petkov
2018-05-04 5:59 ` [PATCH 03/17] efi: Fix IA32/X64 Processor Error Record definition Ard Biesheuvel
2018-05-14 7:44 ` [tip:efi/core] " tip-bot for Yazen Ghannam
2018-05-04 5:59 ` [PATCH 04/17] efi: Decode IA32/X64 Processor Error Section Ard Biesheuvel
2018-05-14 7:45 ` [tip:efi/core] " tip-bot for Yazen Ghannam
2018-05-04 5:59 ` [PATCH 05/17] efi: Decode IA32/X64 Processor Error Info Structure Ard Biesheuvel
2018-05-14 7:45 ` [tip:efi/core] " tip-bot for Yazen Ghannam
2018-05-04 5:59 ` [PATCH 06/17] efi: Decode UEFI-defined IA32/X64 Error Structure GUIDs Ard Biesheuvel
2018-05-14 7:46 ` [tip:efi/core] " tip-bot for Yazen Ghannam
2018-05-04 5:59 ` [PATCH 07/17] efi: Decode IA32/X64 Cache, TLB, and Bus Check structures Ard Biesheuvel
2018-05-14 7:46 ` [tip:efi/core] " tip-bot for Yazen Ghannam
2018-05-04 5:59 ` [PATCH 08/17] efi: Decode additional IA32/X64 Bus Check fields Ard Biesheuvel
2018-05-14 7:47 ` [tip:efi/core] " tip-bot for Yazen Ghannam
2018-05-04 5:59 ` [PATCH 09/17] efi: Decode IA32/X64 MS Check structure Ard Biesheuvel
2018-05-14 7:47 ` [tip:efi/core] " tip-bot for Yazen Ghannam
2018-05-04 5:59 ` [PATCH 10/17] efi: Decode IA32/X64 Context Info structure Ard Biesheuvel
2018-05-14 7:48 ` [tip:efi/core] " tip-bot for Yazen Ghannam
2018-05-04 5:59 ` [PATCH 11/17] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static Ard Biesheuvel
2018-05-14 7:48 ` [tip:efi/core] " tip-bot for Wei Yongjun
2018-05-04 5:59 ` [PATCH 12/17] efi: fix efi_pci_io_protocol32 prototype for mixed mode Ard Biesheuvel
2018-05-14 6:57 ` Ingo Molnar
2018-05-14 7:02 ` Ard Biesheuvel
2018-05-14 7:42 ` [tip:efi/core] efi: Avoid potential crashes, fix the 'struct efi_pci_io_protocol_32' definition " tip-bot for Ard Biesheuvel
2018-05-04 5:59 ` [PATCH 13/17] efi: align efi_pci_io_protocol typedefs to type naming convention Ard Biesheuvel
2018-05-14 7:49 ` [tip:efi/core] efi: Align " tip-bot for Ard Biesheuvel
2018-05-04 6:00 ` [PATCH 14/17] efi/x86: fold __setup_efi_pci32 and __setup_efi_pci64 into one Ard Biesheuvel
2018-05-14 7:49 ` [tip:efi/core] efi/x86: Fold __setup_efi_pci32() and __setup_efi_pci64() into one function tip-bot for Ard Biesheuvel
2018-05-04 6:00 ` [PATCH 15/17] efi/x86: Ignore unrealistically large option roms Ard Biesheuvel
2018-05-14 6:40 ` Ingo Molnar
2018-05-14 6:43 ` [PATCH] efi/x86: Clean up the eboot code a bit Ingo Molnar
2018-05-14 6:47 ` Ard Biesheuvel
2018-05-14 6:58 ` Ingo Molnar
2018-05-14 6:59 ` Ard Biesheuvel [this message]
2018-05-14 7:50 ` [tip:efi/core] efi/x86: Ignore unrealistically large option ROMs tip-bot for Hans de Goede
2018-05-15 9:18 ` Ard Biesheuvel
2018-06-21 15:13 ` Ingo Molnar
2018-05-04 6:00 ` [PATCH 16/17] efi/capsule-loader: Don't output reset log when reset flags are not set Ard Biesheuvel
2018-05-14 7:50 ` [tip:efi/core] " tip-bot for Shunyong Yang
2018-05-04 6:00 ` [PATCH 17/17] efi/libstub/arm64: handle randomized TEXT_OFFSET Ard Biesheuvel
2018-05-14 6:47 ` Ingo Molnar
2018-05-14 6:48 ` Ard Biesheuvel
2018-05-14 7:00 ` Ingo Molnar
2018-05-14 7:01 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu9gzHXNfHwZAoXfOX4F-UbsGjbjZce-iD00E-uqRrC88Q@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=hdegoede@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).