From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B650C35E04 for ; Tue, 25 Feb 2020 17:58:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 265CF2176D for ; Tue, 25 Feb 2020 17:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582653513; bh=Sva3j0zxk8ZOvePoBklb1lV/d69k6BLltGcoL8zx+i8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=F1aM9HARXoGY3nF7mglfMfIdCUcANN/eVYn+YrkLG5aNER/hT4IOcsRwcTEvfpcBL hEJ30Z0GbcKnWC0rvPLcwvHj9aHA7JQl3OPqf2eXraPHSWy02aV+wTBo2Czaz6cIog Ayxey1p8VzOxG+DhuYAshpf2bqIySIEZ4a67ysd8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731170AbgBYR6c (ORCPT ); Tue, 25 Feb 2020 12:58:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:42596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730582AbgBYR6c (ORCPT ); Tue, 25 Feb 2020 12:58:32 -0500 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F048024672 for ; Tue, 25 Feb 2020 17:58:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582653511; bh=Sva3j0zxk8ZOvePoBklb1lV/d69k6BLltGcoL8zx+i8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XvibRSSoNRmYfm+qIPIN7nGGePEDaM41FlNmAuDbFkQjS98jnypCTx3K7+hk1vN2/ M/lQCP9nHUXhPsxFFSSFNpzmY/5oXAOoWByYfG7uXgQ6bYNEqrMDvD9uDvFaTSYfzq f+9pjizLNvqqgFV8yly2QYf2270oA547XfqE0UTY= Received: by mail-wm1-f53.google.com with SMTP id a6so115068wme.2 for ; Tue, 25 Feb 2020 09:58:30 -0800 (PST) X-Gm-Message-State: APjAAAXMjfXq3+Hb/hHHN3tbITbEGeuma56JREscXyz/qnZJd0GsevwB 1Al3P1IKmP3/QVC0TYFUlj1xztk50RLhQe4iKDbmWg== X-Google-Smtp-Source: APXvYqxhDCWtAL9XVlcgMQcvnJk1Yjnsuht22saRgp4RLN0yPuLVMLnzI7N2hk/Y4yIm7rpnYZjw7y3JX1RRjlmthUI= X-Received: by 2002:a7b:c4cc:: with SMTP id g12mr477751wmk.68.1582653509278; Tue, 25 Feb 2020 09:58:29 -0800 (PST) MIME-Version: 1.0 References: <261ea8108c6290e95962be2638bd204f90787c1c.1582652466.git.thomas.lendacky@amd.com> <9e16fed9-4399-5c78-cbfb-6be75c295f31@amd.com> In-Reply-To: <9e16fed9-4399-5c78-cbfb-6be75c295f31@amd.com> From: Ard Biesheuvel Date: Tue, 25 Feb 2020 18:58:18 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] x86/efi: Add additional efi tables for unencrypted mapping checks To: Tom Lendacky Cc: Linux Kernel Mailing List , "the arch/x86 maintainers" , linux-efi , platform-driver-x86@vger.kernel.org, Darren Hart , Andy Shevchenko , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Feb 2020 at 18:54, Tom Lendacky wrote: > > On 2/25/20 11:45 AM, Ard Biesheuvel wrote: > > On Tue, 25 Feb 2020 at 18:41, Tom Lendacky wrote: > >> > >> When booting with SME active, EFI tables must be mapped unencrypted since > >> they were built by UEFI in unencrypted memory. Update the list of tables > >> to be checked during early_memremap() processing to account for new EFI > >> tables. > >> > >> This fixes a bug where an EFI TPM log table has been created by UEFI, but > >> it lives in memory that has been marked as usable rather than reserved. > >> > >> Signed-off-by: Tom Lendacky > >> > >> --- > >> Changes since v1: > >> - Re-spun against EFI tree > > > > Which one? Surely not the one in the link I included? > > I did a git clone of > > git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git > > and checked out branch next. Not sure what I missed... > Weird. Do you see commit 5d288dbd88606d8f215c7138b10649115d79cadd on that branch? It removes rng_seed from struct efi, hence my request to rebase your patch. IMO, best is to simply drop the 'static' from rng_seed, rename it to efi_rng_seed, and drop an extern declaration in linux/efi.h so it is accessible from your code. I'm reluctant to put it back in struct efi.