From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753122AbbIBKAy (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Sep 2015 06:00:54 -0400
Received: from mail-ig0-f172.google.com ([209.85.213.172]:34981 "EHLO
	mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752082AbbIBKAx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Sep 2015 06:00:53 -0400
MIME-Version: 1.0
In-Reply-To: <55E6C4A2.7080307@arm.com>
References: <1439465645-22584-1-git-send-email-suzuki.poulose@arm.com>
	<1439465645-22584-3-git-send-email-suzuki.poulose@arm.com>
	<CAKv+Gu-0ut3o3iy322tbyqLAmR_gfzoE5272O3U3qSd5Zoh0Hw@mail.gmail.com>
	<55E6C4A2.7080307@arm.com>
Date: Wed, 2 Sep 2015 12:00:52 +0200
Message-ID: <CAKv+Gu_VUSxTNb1muM8qykWjHQjcuys+_1Dfa37xRjGE5G+QGA@mail.gmail.com>
Subject: Re: [PATCH 02/14] arm64: Handle section maps for swapper/idmap
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        KVM devel mailing list <kvm@vger.kernel.org>,
        "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
        Catalin Marinas <Catalin.Marinas@arm.com>,
        Will Deacon <Will.Deacon@arm.com>, Mark Rutland <Mark.Rutland@arm.com>,
        Marc Zyngier <Marc.Zyngier@arm.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2 September 2015 at 11:42, Suzuki K. Poulose <Suzuki.Poulose@arm.com> wrote:
> On 02/09/15 10:38, Ard Biesheuvel wrote:
>>
>> On 13 August 2015 at 13:33, Suzuki K. Poulose <suzuki.poulose@arm.com>
>> wrote:
>>>
>>> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
>>>
>>> We use section maps with 4K page size to create the
>>> swapper/idmaps. So far we have used !64K or 4K checks
>>> to handle the case where we use the section maps. This
>>> patch adds a symbol to make it clear those cases.
>>>
>>
>> That sentence does not make sense.
>
>
> I agree. How about :
>
> "This patch adds a new symbol, 'ARM64_SWAPPER_USES_SECTION_MAPS', to
> handle cases where we use section maps, instead of using the page size
> symbols."
>

Yep, much better