From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Kees Cook <keescook@chromium.org>,
Mark Rutland <mark.rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 3/4] arm64: kaslr: Fix incorrect placement of __initdata and __read_mostly
Date: Fri, 12 Aug 2016 14:02:40 +0200 [thread overview]
Message-ID: <CAKv+Gu_ci37u6av9gjchBTVwoMCiqdnwtnDHxLT3cV3+kG0wUw@mail.gmail.com> (raw)
In-Reply-To: <1470988871-2799-4-git-send-email-jszhang@marvell.com>
Hi Jisheng,
On 12 August 2016 at 10:01, Jisheng Zhang <jszhang@marvell.com> wrote:
> __initdata and __read_mostly should be placed after the variable name
> for the variable to be placed in the intended section.
>
Why?
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> arch/arm64/kernel/kaslr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/kaslr.c b/arch/arm64/kernel/kaslr.c
> index b054691..8ebabc4 100644
> --- a/arch/arm64/kernel/kaslr.c
> +++ b/arch/arm64/kernel/kaslr.c
> @@ -20,8 +20,8 @@
> #include <asm/pgtable.h>
> #include <asm/sections.h>
>
> -u64 __read_mostly module_alloc_base;
> -u16 __initdata memstart_offset_seed;
> +u64 module_alloc_base __read_mostly;
> +u16 memstart_offset_seed __initdata;
>
> static __init u64 get_kaslr_seed(void *fdt)
> {
> --
> 2.8.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-08-12 12:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 8:01 [PATCH v3 0/4] arm64: put objects into proper sections Jisheng Zhang
2016-08-12 8:01 ` [PATCH v3 1/4] arm64: vdso: add __init section marker to alloc_vectors_page Jisheng Zhang
2016-08-12 8:01 ` [PATCH v3 2/4] arm64: vdso: constify vm_special_mapping used for aarch32 vectors page Jisheng Zhang
2016-08-12 8:01 ` [PATCH v3 3/4] arm64: kaslr: Fix incorrect placement of __initdata and __read_mostly Jisheng Zhang
2016-08-12 12:02 ` Ard Biesheuvel [this message]
2016-08-15 4:52 ` Jisheng Zhang
2016-08-15 5:57 ` Jisheng Zhang
2016-08-15 6:30 ` Ard Biesheuvel
2016-08-12 8:01 ` [PATCH v3 4/4] arm64: apply __ro_after_init to some objects Jisheng Zhang
2016-08-12 12:43 ` Mark Rutland
2016-08-15 6:53 ` Jisheng Zhang
2016-08-15 9:07 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_ci37u6av9gjchBTVwoMCiqdnwtnDHxLT3cV3+kG0wUw@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=jszhang@marvell.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).