From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: synquacer: fix fall-through annotation
Date: Fri, 14 Sep 2018 08:07:20 +0200 [thread overview]
Message-ID: <CAKv+Gu_ny+CZ+SRT2bN2UdrxVchxeSdd999Eqy91fwJEG=MEmg@mail.gmail.com> (raw)
In-Reply-To: <20180913185913.GA8471@embeddedor.com>
On 13 September 2018 at 20:59, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> Replace "fallthru" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> drivers/i2c/busses/i2c-synquacer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-synquacer.c b/drivers/i2c/busses/i2c-synquacer.c
> index 915f5ed..2184b7c 100644
> --- a/drivers/i2c/busses/i2c-synquacer.c
> +++ b/drivers/i2c/busses/i2c-synquacer.c
> @@ -404,7 +404,7 @@ static irqreturn_t synquacer_i2c_isr(int irq, void *dev_id)
> if (i2c->state == STATE_READ)
> goto prepare_read;
>
> - /* fallthru */
> + /* fall through */
>
> case STATE_WRITE:
> if (bsr & SYNQUACER_I2C_BSR_LRB) {
> --
> 2.7.4
>
prev parent reply other threads:[~2018-09-14 6:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 18:59 [PATCH] i2c: synquacer: fix fall-through annotation Gustavo A. R. Silva
2018-09-14 6:07 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu_ny+CZ+SRT2bN2UdrxVchxeSdd999Eqy91fwJEG=MEmg@mail.gmail.com' \
--to=ard.biesheuvel@linaro.org \
--cc=gustavo@embeddedor.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).