From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753255AbdBGIH3 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Feb 2017 03:07:29 -0500
Received: from mail-it0-f41.google.com ([209.85.214.41]:36022 "EHLO
        mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753201AbdBGIH2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Feb 2017 03:07:28 -0500
MIME-Version: 1.0
In-Reply-To: <20170207075219.GB24528@gmail.com>
References: <1486380166-31868-1-git-send-email-ard.biesheuvel@linaro.org>
 <1486380166-31868-4-git-send-email-ard.biesheuvel@linaro.org> <20170207075219.GB24528@gmail.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Tue, 7 Feb 2017 08:07:26 +0000
Message-ID: <CAKv+Gu_tMgs3Rfn5TvajEapxrQA7kWObgMfF0HmR6YGwfoJ9Qg@mail.gmail.com>
Subject: Re: [PATCH 3/7] efi: Add SHIM and image security database GUID definitions
To: Ingo Molnar <mingo@kernel.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
        Thomas Gleixner <tglx@linutronix.de>,
        "H . Peter Anvin" <hpa@zytor.com>, David Howells <dhowells@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        Josh Boyer <jwboyer@fedoraproject.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7 February 2017 at 07:52, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
>> From: David Howells <dhowells@redhat.com>
>>
>> Add the definitions for shim and image security database, both of which
>> are used widely in various Linux distros.
>>
>> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
>> Signed-off-by: David Howells <dhowells@redhat.com>
>> Cc: Matt Fleming <matt@codeblueprint.co.uk>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> That's not a valid SOB chain: the SOB of the author of the patch (David Howells)
> must come first.
>
> I changed it to:
>
>   Signed-off-by: David Howells <dhowells@redhat.com>
>   Acked-by: Josh Boyer <jwboyer@fedoraproject.org>
>   Cc: Matt Fleming <matt@codeblueprint.co.uk>
>   Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Please holler if that's not OK.
>

Ah yes, thanks for spotting that.

OK with me