From: Paul Taysom <taysom@google.com>
To: Josh Boyer <jwboyer@gmail.com>
Cc: Paul Taysom <taysom@chromium.org>,
Mandeep Baines <msb@chromium.org>,
Olof Johansson <olofj@chromium.org>, Greg KH <greg@kroah.com>,
Jens Axboe <axboe@kernel.dk>, Theodore Tso <tytso@google.com>,
Andrew Morton <akpm@google.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: Fix mod_timer crash when removing USB sticks
Date: Fri, 13 Jan 2012 07:39:25 -0800 [thread overview]
Message-ID: <CAKwO_5EjZCOKLYu2eZz8guTSRJw6-A5SHp23dEhW3cSo6P3KLQ@mail.gmail.com> (raw)
In-Reply-To: <CA+5PVA7Yffs3-qdq6pSqDKLLngU7kBsdE92e31NnAM0=wrwp4w@mail.gmail.com>
On Thu, Jan 12, 2012 at 9:42 PM, Josh Boyer <jwboyer@gmail.com> wrote:
> On Thu, Jan 12, 2012 at 4:15 PM, Paul Taysom <taysom@chromium.org> wrote:
>> From: Paul Taysom <taysom@google.com>
>>
>> A USB stick with a ext file system on it, would occasionally crash
>> when the stick was pulled.
>>
>> The problem was a timer was being set on the Backing Device Interface,
>> bdi, after the USB device had been removed and the bdi had been
>> unregistered. The bdi would then be later reinitialized by zeroing
>> the timer without removing from the timer from the timer queue.
>> This would eventually result in a kernel crash (NULL ptr dereference).
>
> What backtrace did you see when it crashed? There have been a number of
> reports where sd_revalidate_disk is at the top of the backtrace and this sounds
> like it might be related.
>
> josh
I had several different crash traces some can be seen in
http://crosbug.com/24165
The reason that there are different crash traces is that the code path
to crash would just be the victim of the memory corruption caused
earlier. However, most of them had to do with setting or clearing
timers. There are additional problems related to lost I/O requests
that I'm still looking at.
-Paul
next prev parent reply other threads:[~2012-01-13 15:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 21:15 [PATCH] fs: Fix mod_timer crash when removing USB sticks Paul Taysom
2012-01-12 21:38 ` Greg KH
2012-01-12 21:53 ` Mandeep Singh Baines
2012-01-12 22:02 ` Greg KH
2012-01-12 22:11 ` Theodore Tso
[not found] ` <CAGagf4dk4KsZSkaWTO9Yegi=_wRJsYBPgfyks1z=wMZJV8gX0w@mail.gmail.com>
2012-01-12 22:35 ` Mandeep Singh Baines
2012-01-12 23:23 ` Andrew Morton
2012-01-13 5:42 ` Josh Boyer
2012-01-13 15:39 ` Paul Taysom [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-12 21:57 Paul Taysom
2012-03-16 17:36 ` Greg KH
2012-03-16 19:29 ` Paul Taysom
2012-03-16 19:43 ` Greg KH
2012-03-16 21:10 ` Theodore Tso
2012-03-17 0:06 ` Greg KH
2012-03-17 14:21 ` Alan Stern
2012-03-18 3:44 ` Ted Ts'o
2012-03-18 20:23 ` Alan Stern
2012-03-18 22:25 ` Mandeep Singh Baines
2012-03-20 0:24 ` Paul Taysom
2012-03-20 2:02 ` Alan Stern
2012-03-22 16:15 ` Paul Taysom
2012-01-12 19:57 Paul Taysom
2012-01-12 20:15 ` Greg KH
2012-01-13 11:28 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwO_5EjZCOKLYu2eZz8guTSRJw6-A5SHp23dEhW3cSo6P3KLQ@mail.gmail.com \
--to=taysom@google.com \
--cc=akpm@google.com \
--cc=axboe@kernel.dk \
--cc=greg@kroah.com \
--cc=jwboyer@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=msb@chromium.org \
--cc=olofj@chromium.org \
--cc=taysom@chromium.org \
--cc=tytso@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).