From: Nick Desaulniers <ndesaulniers@google.com>
To: Stefan Agner <stefan@agner.ch>
Cc: Russell King <linux@armlinux.org.uk>,
Fangrui Song <maskray@google.com>, Jian Cai <jiancai@google.com>,
Peter Smith <peter.smith@linaro.org>,
Hans Ulli Kroll <ulli.kroll@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Pitre <nico@fluxnic.net>, Enrico Weigelt <info@metux.net>,
Thomas Gleixner <tglx@linutronix.de>,
Roy Franz <rfranz@marvell.com>,
Linus Walleij <linus.walleij@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Allison Randal <allison@lohutok.net>,
Richard Fontana <rfontana@redhat.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Dave Martin <Dave.Martin@arm.com>,
Sonny Rao <sonnyrao@chromium.org>,
Doug Anderson <armlinux@m.disordat.com>,
Vladimir Murzin <vladimir.murzin@arm.com>,
afzal mohammed <afzal.mohd.ma@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] arm: replace Sun/Solaris style flag on section directive
Date: Mon, 4 Nov 2019 10:43:08 -0800 [thread overview]
Message-ID: <CAKwvOd==f801+AfJWwrO3tbSRoizCa2HV7pViOqedJbipN9nOw@mail.gmail.com> (raw)
In-Reply-To: <fa4e28a9a16c54319916be005159e250@agner.ch>
On Fri, Nov 1, 2019 at 2:05 PM Stefan Agner <stefan@agner.ch> wrote:
>
> Hi Nick,
>
> On 2019-10-30 18:44, Nick Desaulniers wrote:
> > It looks like a section directive was using "Solaris style" to declare
> > the section flags. Replace this with the GNU style so that Clang's
> > integrated assembler can assemble this directive.
> >
> > The modified instances were identified via:
> > $ ag \\.section | grep \#
Submitted: https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8933/1
>
> I actually have the *very same* patch on my tree, just did not cleanup
> the commit message and submit :-(
Send in those patches!
>
> Anyways, this looks good to me:
>
> Reviewed-by: Stefan Agner <stefan@agner.ch>
Thanks all for those reviews.
--
Thanks,
~Nick Desaulniers
prev parent reply other threads:[~2019-11-04 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 17:44 [PATCH] arm: replace Sun/Solaris style flag on section directive Nick Desaulniers
2019-10-31 8:22 ` Ard Biesheuvel
2019-10-31 17:31 ` Nicolas Pitre
2019-11-01 21:05 ` Stefan Agner
2019-11-04 18:43 ` Nick Desaulniers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOd==f801+AfJWwrO3tbSRoizCa2HV7pViOqedJbipN9nOw@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=Dave.Martin@arm.com \
--cc=afzal.mohd.ma@gmail.com \
--cc=allison@lohutok.net \
--cc=ard.biesheuvel@linaro.org \
--cc=armlinux@m.disordat.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=jiancai@google.com \
--cc=kstewart@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maskray@google.com \
--cc=nico@fluxnic.net \
--cc=peter.smith@linaro.org \
--cc=rfontana@redhat.com \
--cc=rfranz@marvell.com \
--cc=sonnyrao@chromium.org \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=ulli.kroll@googlemail.com \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).