From: Nick Desaulniers <ndesaulniers@google.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kbuild@vger.kernel.org
Cc: Michael Davidson <md@google.com>,
Greg Hackmann <ghackmann@google.com>,
Pirama Arumuga Nainar <pirama@google.com>,
Ingo Molnar <mingo@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Arnd Bergmann <arnd@arndb.de>,
Mark Charlebois <charlebm@gmail.com>,
Cao jin <caoj.fnst@cn.fujitsu.com>,
Marcin Nowakowski <marcin.nowakowski@imgtec.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: fix linker feature test macros when cross compiling with Clang
Date: Fri, 27 Oct 2017 11:28:43 -0700 [thread overview]
Message-ID: <CAKwvOd=COgOc4MM7Ex1j8d_fXDuW0uUTueUEr-bL7NESB4hrWw@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNASyP3x8wnvv_Eo_CbHehY5+pPjcpJFAn3fw8NAAi00GQA@mail.gmail.com>
+ linux-kbuild@vger.kernel.org
On Fri, Oct 27, 2017 at 4:20 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> I do not like to add $(CLANG_TARGET) to a place for common helpers.
> Instead of $(CLANG_TARGET), please add
> $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS)
> to cc-ldoption and ld-option.
Thanks for the review. I agree that sounds like a better option.
> I have two requests next time:
> - please include linux-kbuild@vger.kernel.org in your To list
Sure thing. scripts/get_maintainer.pl does not recommend that list for
this file; is there a way to explicitly add that list to the
recommendation for that source file?
> - please base your patch on linux-kbuild/kbuild branch
Will do. Do I need to note it's based off that branch? Otherwise wont
0-day bot complain that my patch doesn't apply/build on torvalds/linux
?
next prev parent reply other threads:[~2017-10-27 18:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 20:17 [PATCH] kbuild: fix linker feature test macros when cross compiling with Clang Nick Desaulniers
2017-10-27 11:20 ` Masahiro Yamada
2017-10-27 18:28 ` Nick Desaulniers [this message]
2017-10-27 20:10 ` Nick Desaulniers
2017-10-28 14:59 ` Masahiro Yamada
2017-10-27 20:13 ` [PATCH v2] " Nick Desaulniers
2017-10-28 15:00 ` Masahiro Yamada
2017-10-30 6:50 ` Masahiro Yamada
2017-10-30 15:46 ` Masahiro Yamada
2017-10-30 16:13 ` Nick Desaulniers
2017-11-06 18:47 ` Nick Desaulniers
2017-11-06 18:47 ` [PATCH v3] " Nick Desaulniers
2017-11-07 3:41 ` Masahiro Yamada
2017-12-11 10:17 ` Arnd Bergmann
2017-12-11 11:47 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOd=COgOc4MM7Ex1j8d_fXDuW0uUTueUEr-bL7NESB4hrWw@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=arnd@arndb.de \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=charlebm@gmail.com \
--cc=ghackmann@google.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.nowakowski@imgtec.com \
--cc=md@google.com \
--cc=mingo@kernel.org \
--cc=mka@chromium.org \
--cc=pirama@google.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).