From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83CB9C433F5 for ; Tue, 3 May 2022 21:55:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243297AbiECV6o (ORCPT ); Tue, 3 May 2022 17:58:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238124AbiECV6h (ORCPT ); Tue, 3 May 2022 17:58:37 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FE4A4198E for ; Tue, 3 May 2022 14:55:04 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id c15so23651943ljr.9 for ; Tue, 03 May 2022 14:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mRqQ6md8oXZUAxpQNWuFfsuLgkVAHVB4ABTBtcxd60I=; b=KXwmzUG9fBG72FLoLS+CkAITuvrHFe1o4QZNhYyhhpbF3sZAczPRJyCiFaqmIsS2TO 0n1ajjwyfuR9TDh4prbEzV/CMMuK2DAK0gG7DfyaUI6CL4XQOuI6tUyHH6MLeal3jVq2 6omx5v/dEDq61WiyuOKe+tqsbEXQ0DZvpMctxmsgmXuc6BgCDGMhd5seZn6JAd3cGAoj PR12btlln8MIyvOYGGX5TZRg1Gx00znlGnbGc2R8B2TCD9C7DW5dAxqk2kHcpAj62SMT 9EY7nj2Y6XF6hVkxfN/2lMI/h160zU2UxyBtH4XSaT9slrFLj6qvXBbixxe0SxvM7SgB G7Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mRqQ6md8oXZUAxpQNWuFfsuLgkVAHVB4ABTBtcxd60I=; b=PQnSrE1F+10vRggFPFenWshAXPIRqKh7Og0WohJ7giVFiuzdw9FB+p7kFws8GznnNz 92uqjdDuaaHyTFyWt8UaoS5TxJR24jDFE7uhIMDies6x+QdrkPcGh5PMNK1TCIQPn5wx 3nJ6Y5zTAWhJGm8Nm8Zpy5O+fz3Ty/7fGtJpT06+/a9jiOrgRKDXQoRSNi7CwrZnidFp rG2kMaUcXoTogWTpHj0Qjj7SVmjGBXhsiwIUf8pEhVKHup5ZS9x0ocW8RsgXcqPt2Ojv TdH+2tkj+hQQExKvkAwL2byNebmbbU2viwdz8BCWy66rSFzmxSEUM4XwtkgNH7awT9fv g8rA== X-Gm-Message-State: AOAM5327Lu3CTsYo5RuclNDtRjCkQzIcOaOZTCxA8g+inah7ltYT73Ma pE/yKC5JAqDz19jZ2z/qNpded7kwXjMpsB9JzwCxZw== X-Google-Smtp-Source: ABdhPJy5wScXsBi82dv7rf9MooYymn4WbuH+TxtXSWPOk1ytvgPuoiZV2R2QHScqc4sUrC0LipOvPjx7Pddq/s59yQw= X-Received: by 2002:a05:651c:1a09:b0:250:5bd1:6daf with SMTP id by9-20020a05651c1a0900b002505bd16dafmr5533750ljb.468.1651614902306; Tue, 03 May 2022 14:55:02 -0700 (PDT) MIME-Version: 1.0 References: <20220501084032.1025918-1-masahiroy@kernel.org> <20220501084032.1025918-11-masahiroy@kernel.org> In-Reply-To: <20220501084032.1025918-11-masahiroy@kernel.org> From: Nick Desaulniers Date: Tue, 3 May 2022 14:54:51 -0700 Message-ID: Subject: Re: [PATCH v2 10/26] modpost: move static EXPORT_SYMBOL check to check_exports() To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Marek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 1, 2022 at 1:42 AM Masahiro Yamada wrote: > > Now that struct module has a list of symbols it exports, this check > can go into check_exports(). The code becomes shorter. > > Signed-off-by: Masahiro Yamada Thanks for the patch! Reviewed-by: Nick Desaulniers > --- > > (no changes since v1) > > scripts/mod/modpost.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index cd49ef7b5953..4ce8d164b8e0 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -2199,6 +2199,12 @@ static void check_exports(struct module *mod) > if (!mod->is_gpl_compatible) > check_for_gpl_usage(exp->export, basename, exp->name); > } > + > + list_for_each_entry(s, &mod->exported_symbols, list) { > + if (s->is_static) > + error("\"%s\" [%s] is a static %s\n", > + s->name, mod->name, export_str(s->export)); > + } > } > > static void check_modname_len(struct module *mod) > @@ -2510,7 +2516,6 @@ int main(int argc, char **argv) > char *missing_namespace_deps = NULL; > char *dump_write = NULL, *files_source = NULL; > int opt; > - int n; > LIST_HEAD(dump_lists); > struct dump_list *dl, *dl2; > > @@ -2606,16 +2611,6 @@ int main(int argc, char **argv) > if (sec_mismatch_count && !sec_mismatch_warn_only) > error("Section mismatches detected.\n" > "Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.\n"); > - for (n = 0; n < SYMBOL_HASH_SIZE; n++) { > - struct symbol *s; > - > - for (s = symbolhash[n]; s; s = s->next) { > - if (s->is_static) > - error("\"%s\" [%s] is a static %s\n", > - s->name, s->module->name, > - export_str(s->export)); > - } > - } > > if (nr_unresolved > MAX_UNRESOLVED_REPORTS) > warn("suppressed %u unresolved symbol warnings because there were too many)\n", > -- > 2.32.0 > -- Thanks, ~Nick Desaulniers