From: Nick Desaulniers <ndesaulniers@google.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
efriedma@codeaurora.org, sparse@chrisli.org,
Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
joe@perches.com, asmadeus@codewreck.org
Subject: Re: [PATCH 2/7] Compiler Attributes: use the no-underscores syntax
Date: Fri, 31 Aug 2018 11:51:48 -0700 [thread overview]
Message-ID: <CAKwvOd=M8H+95qh36-xMA6F7BD1TbOFO_cP8zrVhCBCyCy7e9Q@mail.gmail.com> (raw)
In-Reply-To: <20180831170514.24665-2-miguel.ojeda.sandonis@gmail.com>
On Fri, Aug 31, 2018 at 10:05 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> The attribute syntax optionally allows to surround attribute names
> with "__" in order to avoid collisions with macros of the same name
> (see https://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html).
>
> This homogenizes all attributes to use the syntax without underscores.
>
> Cc: Eli Friedman <efriedma@codeaurora.org>
> Cc: Christopher Li <sparse@chrisli.org>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Joe Perches <joe@perches.com>
> Cc: Dominique Martinet <asmadeus@codewreck.org>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> ---
> include/linux/compiler-clang.h | 2 +-
> include/linux/compiler-gcc.h | 4 ++--
> include/linux/compiler.h | 4 ++--
> include/linux/compiler_types.h | 8 ++++----
> 4 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h
> index b1ce500fe8b3..efda74f4eeba 100644
> --- a/include/linux/compiler-clang.h
> +++ b/include/linux/compiler-clang.h
> @@ -43,4 +43,4 @@
> #define barrier() __asm__ __volatile__("" : : : "memory")
> #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
> #define __assume_aligned(a, ...) \
> - __attribute__((__assume_aligned__(a, ## __VA_ARGS__)))
> + __attribute__((assume_aligned(a, ## __VA_ARGS__)))
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index 0a2d06677d83..dbfbecf703f8 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -132,7 +132,7 @@
> } while (0)
>
> /* Mark a function definition as prohibited from being cloned. */
> -#define __noclone __attribute__((__noclone__, __optimize__("no-tracer")))
> +#define __noclone __attribute__((noclone, optimize("no-tracer")))
>
> #if defined(RANDSTRUCT_PLUGIN) && !defined(__CHECKER__)
> #define __randomize_layout __attribute__((randomize_layout))
> @@ -165,7 +165,7 @@
> * compiler should see some alignment anyway, when the return value is
> * massaged by 'flags = ptr & 3; ptr &= ~3;').
> */
> -#define __assume_aligned(a, ...) __attribute__((__assume_aligned__(a, ## __VA_ARGS__)))
> +#define __assume_aligned(a, ...) __attribute__((assume_aligned(a, ## __VA_ARGS__)))
> #endif
>
> /*
> diff --git a/include/linux/compiler.h b/include/linux/compiler.h
> index 7c0157d50964..e0e55eb3f242 100644
> --- a/include/linux/compiler.h
> +++ b/include/linux/compiler.h
> @@ -23,7 +23,7 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int val,
> #define __branch_check__(x, expect, is_constant) ({ \
> long ______r; \
> static struct ftrace_likely_data \
> - __attribute__((__aligned__(4))) \
> + __attribute__((aligned(4))) \
Can this be __aligned(4)? As in make use of the newly feature detected
attributes?
> __attribute__((section("_ftrace_annotated_branch"))) \
Sorry to ask for cleanups on code you didn't touch, but since you're
here, can you make this __section("_ftrace_annotated_branch")?
> ______f = { \
> .data.func = __func__, \
> @@ -59,7 +59,7 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int val,
> ({ \
> int ______r; \
> static struct ftrace_branch_data \
> - __attribute__((__aligned__(4))) \
> + __attribute__((aligned(4))) \
> __attribute__((section("_ftrace_branch"))) \
Ditto.
> ______f = { \
> .func = __func__, \
> diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h
> index b6534292ea33..7cd958360ead 100644
> --- a/include/linux/compiler_types.h
> +++ b/include/linux/compiler_types.h
> @@ -159,7 +159,7 @@ struct ftrace_likely_data {
> sizeof(t) == sizeof(int) || sizeof(t) == sizeof(long))
>
> #ifndef __attribute_const__
> -#define __attribute_const__ __attribute__((__const__))
> +#define __attribute_const__ __attribute__((const))
> #endif
>
> #ifndef __noclone
> @@ -203,14 +203,14 @@ struct ftrace_likely_data {
> #define __maybe_unused __attribute__((unused))
> #define __always_unused __attribute__((unused))
> #define __mode(x) __attribute__((mode(x)))
> -#define __malloc __attribute__((__malloc__))
> -#define __used __attribute__((__used__))
> +#define __malloc __attribute__((malloc))
> +#define __used __attribute__((used))
> #define __noreturn __attribute__((noreturn))
> #define __packed __attribute__((packed))
> #define __weak __attribute__((weak))
> #define __alias(symbol) __attribute__((alias(#symbol)))
> #define __cold __attribute__((cold))
> -#define __section(S) __attribute__((__section__(#S)))
> +#define __section(S) __attribute__((section(#S)))
>
>
> #ifdef CONFIG_ENABLE_MUST_CHECK
> --
> 2.17.1
>
With the above changes requested (or follow up patch added to the series):
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Also,
Series looks great, trying to provide reviews one by one, just very
busy today (and Monday off).
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2018-08-31 18:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 17:05 [PATCH 1/7] Compiler Attributes: remove unused attributes Miguel Ojeda
2018-08-31 17:05 ` [PATCH 2/7] Compiler Attributes: use the no-underscores syntax Miguel Ojeda
2018-08-31 18:51 ` Nick Desaulniers [this message]
2018-08-31 19:17 ` Miguel Ojeda
2018-08-31 21:49 ` Rasmus Villemoes
2018-08-31 22:10 ` Miguel Ojeda
2018-08-31 22:40 ` Miguel Ojeda
2018-09-03 6:42 ` Geert Uytterhoeven
2018-09-03 10:40 ` Miguel Ojeda
2018-08-31 17:05 ` [PATCH 3/7] Compiler Attributes: remove unneeded tests Miguel Ojeda
2018-08-31 21:10 ` Nick Desaulniers
2018-09-01 8:16 ` kbuild test robot
2018-09-01 9:56 ` kbuild test robot
2018-08-31 17:05 ` [PATCH 4/7] Compiler Attributes: homogenize __must_be_array Miguel Ojeda
2018-08-31 21:16 ` Nick Desaulniers
2018-09-01 9:17 ` Luc Van Oostenryck
2018-09-01 12:11 ` Miguel Ojeda
2018-08-31 17:05 ` [PATCH 5/7] Compiler Attributes: naked was fixed in gcc 4.6 Miguel Ojeda
2018-08-31 19:48 ` Arnd Bergmann
2018-08-31 20:26 ` Miguel Ojeda
2018-08-31 17:05 ` [PATCH 6/7] Compiler Attributes: remove unneeded sparse (__CHECKER__) tests Miguel Ojeda
2018-08-31 21:38 ` Nick Desaulniers
2018-08-31 21:55 ` Miguel Ojeda
2018-08-31 22:39 ` Luc Van Oostenryck
2018-08-31 17:05 ` [PATCH 7/7] Compiler Attributes: use feature checks instead of version checks Miguel Ojeda
2018-08-31 23:07 ` Nick Desaulniers
2018-09-01 13:38 ` Miguel Ojeda
2018-09-01 18:39 ` Greg KH
2018-09-01 19:15 ` Miguel Ojeda
2018-09-01 9:24 ` kbuild test robot
2018-09-01 9:51 ` kbuild test robot
2018-09-01 9:56 ` Luc Van Oostenryck
2018-09-01 12:58 ` Miguel Ojeda
2018-09-01 10:14 ` Dominique Martinet
2018-09-01 12:55 ` Miguel Ojeda
2018-09-01 14:17 ` Dominique Martinet
2018-09-03 18:03 ` Miguel Ojeda
2018-08-31 17:27 ` [PATCH 1/7] Compiler Attributes: remove unused attributes Joe Perches
2018-08-31 18:43 ` Nick Desaulniers
2018-08-31 18:53 ` Joe Perches
2018-08-31 20:23 ` Miguel Ojeda
2018-08-31 21:27 ` Nick Desaulniers
2018-09-02 19:54 ` Arnd Bergmann
2018-09-03 11:16 ` Miguel Ojeda
2018-08-31 18:39 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOd=M8H+95qh36-xMA6F7BD1TbOFO_cP8zrVhCBCyCy7e9Q@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=arnd@arndb.de \
--cc=asmadeus@codewreck.org \
--cc=efriedma@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).