From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6135BC4320E for ; Tue, 31 Aug 2021 17:25:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41C5061101 for ; Tue, 31 Aug 2021 17:25:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238093AbhHaR0d (ORCPT ); Tue, 31 Aug 2021 13:26:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231732AbhHaR01 (ORCPT ); Tue, 31 Aug 2021 13:26:27 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80DFDC061575 for ; Tue, 31 Aug 2021 10:25:31 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id j4so315579lfg.9 for ; Tue, 31 Aug 2021 10:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fTdszUcQhCEcNHCRiqUNDLFAJTHQZIWzSNpVbTbX/VY=; b=hUaQwObYAuDbsWA/9uGHjRmUxuNLw6ibIs8E7fB1bhhn+sahRBrK60fDXo7zi1KOFO ClDvMscz9ySY24WS6aBrEjkft2a4scrRSPyE3Mkaf4BvD4HBJsXaxWzYDjv0KoEvTxK1 XpJrTwCzlVTXskwuQ+GprL/stAEU/1zfsYCwFIbDpnxK97eIpMk5FtvLE9dbHPXkXy7k OPnqcJlk4wnpMIA8F6xu7yHE3RXle9jZM4DqYEjHQLOocdS+2sCtMXFoWjpaiXOIBsPC +zWth2fKn78sSbXodB7L9O0qg6LMNoaHuyBiOXF1XgIPjoKBDhzQNeLnMSVzMSjANd+M +CMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fTdszUcQhCEcNHCRiqUNDLFAJTHQZIWzSNpVbTbX/VY=; b=aktN6jh6KL6hcGBVnCiwzbv0aNzT6EF523ZZmJ097EyUEUgTo7w6rg46gXa150PF6d k6SsQ6g1N9qMUQ+xWFV4ilzmFBFFZiOaeLOT550hFYmciPdLrxFwqtPxvWMIYKYEsWI0 tOj6pbKrmAyAm252zdvuqK6ZQAg9G3T8lXx642UPxrUQ89JtT26Nbn9Et1ioo1tNUiN2 Z/OdlaDkMB+fdx7AP+IMkI75DAS+X0/B/cKHA7utM6B7MMN6dPncoo6k1bebdJguUJoa o0gFXUnfw58DO+iXU238EWTcdjjG0vINNkcZ+wv56iqCkxl1refu6NXE+1+TW5udixaa pJ/g== X-Gm-Message-State: AOAM5303rTb1lvXKVO5UXwBHJeKDsB3jRQ7VzYoXbWZ22vLVRAkdbQzP QNYIdlPzyk8KTWvmh3Prr1HzhaXdxi2K2+cAGlFIMQ== X-Google-Smtp-Source: ABdhPJwG8sD3YoVSTL+ENxEtVsaDRitkN3N8Wi0lvrzw+En4HEAswfMkVCcJwYiFVBLTy4KiSOQ9UFB7e6LVd6N9I8c= X-Received: by 2002:a05:6512:1583:: with SMTP id bp3mr21914434lfb.122.1630430729451; Tue, 31 Aug 2021 10:25:29 -0700 (PDT) MIME-Version: 1.0 References: <20210831074004.3195284-1-masahiroy@kernel.org> <20210831074004.3195284-5-masahiroy@kernel.org> In-Reply-To: <20210831074004.3195284-5-masahiroy@kernel.org> From: Nick Desaulniers Date: Tue, 31 Aug 2021 10:25:18 -0700 Message-ID: Subject: Re: [PATCH v2 04/13] kbuild: factor out OBJECT_FILES_NON_STANDARD check into a macro To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Michal Marek , linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 31, 2021 at 12:40 AM Masahiro Yamada wrote: > > The OBJECT_FILES_NON_STANDARD check is quite long. > > Factor it out into a new macro, objtool-enabled, to not repeat it. > > Signed-off-by: Masahiro Yamada Reviewed-by: Nick Desaulniers > --- > > scripts/Makefile.build | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index 021ae0146913..720a86642f48 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -241,12 +241,12 @@ ifndef CONFIG_LTO_CLANG > # 'OBJECT_FILES_NON_STANDARD := y': skip objtool checking for a directory > # 'OBJECT_FILES_NON_STANDARD_foo.o := 'y': skip objtool checking for a file > # 'OBJECT_FILES_NON_STANDARD_foo.o := 'n': override directory skip for a file > -cmd_objtool = $(if $(patsubst y%,, \ > - $(OBJECT_FILES_NON_STANDARD_$(basetarget).o)$(OBJECT_FILES_NON_STANDARD)n), \ > - ; $(objtool) $(objtool_args) $@) > -objtool_obj = $(if $(patsubst y%,, \ > - $(OBJECT_FILES_NON_STANDARD_$(basetarget).o)$(OBJECT_FILES_NON_STANDARD)n), \ > - $(objtool)) > + > +objtool-enabled = $(if $(filter-out y%, \ > + $(OBJECT_FILES_NON_STANDARD_$(basetarget).o)$(OBJECT_FILES_NON_STANDARD)n),y) > + > +cmd_objtool = $(if $(objtool-enabled), ; $(objtool) $(objtool_args) $@) > +objtool_obj = $(if $(objtool-enabled), $(objtool)) > > endif # CONFIG_LTO_CLANG > endif # CONFIG_STACK_VALIDATION > -- > 2.30.2 > -- Thanks, ~Nick Desaulniers