From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 163FEC7618F for ; Tue, 16 Jul 2019 21:18:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3DDF2173E for ; Tue, 16 Jul 2019 21:18:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="X9K+xYg/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730776AbfGPVSq (ORCPT ); Tue, 16 Jul 2019 17:18:46 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:44566 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726558AbfGPVSq (ORCPT ); Tue, 16 Jul 2019 17:18:46 -0400 Received: by mail-pl1-f193.google.com with SMTP id t14so10732076plr.11 for ; Tue, 16 Jul 2019 14:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wditBe2WB9aM35K3GMrXkW9Eb3mbuaueCJdBg7RgTqo=; b=X9K+xYg/Mr3ClCkR3CqDxuRhAzJyF2hHI6uosX6UijK+QI06Ijuw9XKokVXcOns5YS IDW+xteWCZXWXOtj7Gs++wOEc+ERSgctlejLoSisHd+FOfZPmU34VmuoC4skJ/vsTT/d Cc4B8isndGmLenQdVh9wcJj61CqhS56ozkkaI2zDd0/EkNHOzfDOLH3HCSKbNtFbhmtS KACTj0ANGZPgztZIaj4N/J6hb2sHuEEyvH0vtJ355dX7UnDjh+ZVKrMJe0bFADBjzk6Z Oy8eHGeyeZt2W7zeGitJMtYPSW4WfO3z1/rjeIncFZs8kGN2YRKAy0C4DAJ5nyu4fyZs xWhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wditBe2WB9aM35K3GMrXkW9Eb3mbuaueCJdBg7RgTqo=; b=BiEgAhFBDraY5wRaCUkaaI75dG0CPfr3AH/d2A3J0jDyBUVj+uTLzBijlrXawL6BMg q7mH8kUrWD7/HlgrdjsiBb/9/Y15NuIvy1gw+Rz8Fl914LhTu/cR71NzeGFDGRxr/KfA bkV1FY4qnktv6TJcDsoxCL6Yyl0GTvWhhnOsZJhS6Ceb1POdlDkZxlijXkHvBilS/0Bi 68blaOHtPnWiC/m6LhlnhohIAlzOifxNbzSwsuxS3REin9PqAdrD2g3I3eRub18ukoBY j1m5a8sZqpUS1U7mNSyUcPciXXV9aOqxVv72rEVmp09Lw2nWPLfFrsUYDRGXjOXLISHe vPJg== X-Gm-Message-State: APjAAAU1RRbMHruGpQWy7yqKi5oAh1N4KoaAZ+txkyq7EnUGiNh6P6t7 NjvEt0UnsEcpAoqd5Cff/KHHCj6XcAJFVqdRdLCc9Q== X-Google-Smtp-Source: APXvYqwnrM8Dl51SpyXviMrSa+uzxfaYffLjasQcMHtS4jfkOiBYk4on4eI7l3qvvzGgbLP0rZBUES5yd9h3RCu6nVk= X-Received: by 2002:a17:902:b944:: with SMTP id h4mr37579561pls.179.1563311925137; Tue, 16 Jul 2019 14:18:45 -0700 (PDT) MIME-Version: 1.0 References: <20190712001708.170259-1-ndesaulniers@google.com> In-Reply-To: From: Nick Desaulniers Date: Tue, 16 Jul 2019 14:18:33 -0700 Message-ID: Subject: Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static To: Luca Coelho Cc: Joe Perches , Kalle Valo , Arnd Bergmann , Nathan Chancellor , Johannes Berg , Emmanuel Grumbach , Intel Linux Wireless , "David S. Miller" , Shahar S Matityahu , Sara Sharon , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, LKML , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 16, 2019 at 2:15 PM Luca Coelho wrote: > > On Tue, 2019-07-16 at 10:28 -0700, Nick Desaulniers wrote: > > On Thu, Jul 11, 2019 at 7:15 PM Joe Perches wrote: > > > Better still would be to use the format string directly > > > in both locations instead of trying to deduplicate it > > > via storing it into a separate pointer. > > > > > > Let the compiler/linker consolidate the format. > > > It's smaller object code, allows format/argument verification, > > > and is simpler for humans to understand. > > > > Whichever Kalle prefers, I just want my CI green again. > > We already changed this in a later internal patch, which will reach the > mainline (-next) soon. So let's skip this for now. Ok, but this has now regressed into mainline and is blocking Linaro's ToolChain Working Group's CI, so if you could send a bugfix ASAP we'd appreciate it. -- Thanks, ~Nick Desaulniers