From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDC67C2BA1A for ; Tue, 7 Apr 2020 19:03:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2A702072A for ; Tue, 7 Apr 2020 19:03:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Iu7XU9Q1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727126AbgDGTDl (ORCPT ); Tue, 7 Apr 2020 15:03:41 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:47083 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726773AbgDGTDl (ORCPT ); Tue, 7 Apr 2020 15:03:41 -0400 Received: by mail-pf1-f193.google.com with SMTP id q3so1210562pff.13 for ; Tue, 07 Apr 2020 12:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+9ktnBB45aXlgSe0vRhpOUgxZAxDNe5YDUe3z1UsWXQ=; b=Iu7XU9Q1UurBhDGdXS/vYjiFh68jWNQ8e06hHF28IR+07VW9uNQPZ2Orsrw+Pgq9BO doulhBpDbe64U+hrCXWN+604MB1kGpL7KVRePvHJDGez6gbPRuZgDDeyN30VBzawqR6M 5HwFaxk16hCeVhMLwDt73YD8os8sIgrniSikPkS57lMVxuI5/UV0gB1uuMSwVUANffZd 1T4VFWplx4Puxa7YyCVMq95NNiVzc7cVwY9U6ShahHQ6UOUr5uQEOkT7mnuF9mRVqgm4 RqMjYoIoqb/2PtFFXepG8yBz/GVR2+PNOEB8wXFOTqoRX0nG+M0omn2qf5lJGgzM7QWi 4HqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+9ktnBB45aXlgSe0vRhpOUgxZAxDNe5YDUe3z1UsWXQ=; b=Qxe7GJxSQdifVf3GZg3+psiAoAVJwEj8elgSeGCSdrptnCBpXkTCAtPWDNOKx8ED0D jxoM1L/mXpzmpubuuBwpEA92yl5WmTn2q6Z+gCh6RA3HebnvNijKZ7PJ+OAAN9D421h2 pYke/oHzd6cJomJA6rvnGn3iqbB5Bxqzss+xhdyRcme0UQtLZ3E3xoieQy13NEsSDesc wdDxwobOgobTaLX3ftNejvgV12EMPW6lZTUlkPsSS0U9wQAy8q7WVPPFS/A9HJ63wGm1 Zv9n3RrarB6pIwcJmAYI2DaGoO9t0AZf1myEN3JuNicSeP2FMjJawTyUoWRZGcBJ3VAf EcVQ== X-Gm-Message-State: AGi0PuZaKrEH2lp4MeY+FhM1mg/QQatqAh5vVkQfZFvjS4fIV8o2lTFz YhXER9MqnmtU9SyRVT9hgy1bSikWDtkxmVbZaZU+6Q== X-Google-Smtp-Source: APiQypInHGpY7jZ4h51jJj3LKW1TA1Mq84UMe1r78naeeUH4EQq8+MTwZ3cUNL06uiOby8Imllg/eeIxoTxeqrNEbWM= X-Received: by 2002:aa7:919a:: with SMTP id x26mr3880195pfa.39.1586286220287; Tue, 07 Apr 2020 12:03:40 -0700 (PDT) MIME-Version: 1.0 References: <20200407184336.14612-1-masahiroy@kernel.org> In-Reply-To: <20200407184336.14612-1-masahiroy@kernel.org> From: Nick Desaulniers Date: Tue, 7 Apr 2020 12:03:29 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] kbuild: replace AS=clang with LLVM_IA=1 To: Masahiro Yamada Cc: Linux Kbuild mailing list , clang-built-linux , Jonathan Corbet , Michal Marek , Linux Doc Mailing List , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 7, 2020 at 11:44 AM Masahiro Yamada wrote: > > The 'AS' variable is unused for building the kernel. Only the remaining > usage is to turn on the integrated assembler. A boolean flag is a better > fit for this purpose. > > AS=clang was added for experts. So, I replaced it with LLVM_IA=1, > breaking the backward compatibility. > > Suggested-by: Nick Desaulniers > Signed-off-by: Masahiro Yamada Thank you for this series! Reviewed-by: Nick Desaulniers > --- > > Changes in v2: > - new patch > > Documentation/kbuild/llvm.rst | 5 ++++- > Makefile | 2 +- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst > index eefbdfa3e4d9..2b40afa58049 100644 > --- a/Documentation/kbuild/llvm.rst > +++ b/Documentation/kbuild/llvm.rst > @@ -50,11 +50,14 @@ LLVM Utilities > LLVM has substitutes for GNU binutils utilities. These can be invoked as > additional parameters to `make`. > > - make CC=clang AS=clang LD=ld.lld AR=llvm-ar NM=llvm-nm STRIP=llvm-strip \\ > + make CC=clang LD=ld.lld AR=llvm-ar NM=llvm-nm STRIP=llvm-strip \\ > OBJCOPY=llvm-objcopy OBJDUMP=llvm-objdump OBJSIZE=llvm-size \\ > READELF=llvm-readelf HOSTCC=clang HOSTCXX=clang++ HOSTAR=llvm-ar \\ > HOSTLD=ld.lld > > +Currently, the integrated assembler is disabled by default. You can pass > +LLVM_IA=1 to enable it. > + > Getting Help > ------------ > > diff --git a/Makefile b/Makefile > index 1b2691057cb5..f9beb696d6d3 100644 > --- a/Makefile > +++ b/Makefile > @@ -538,7 +538,7 @@ endif > ifneq ($(GCC_TOOLCHAIN),) > CLANG_FLAGS += --gcc-toolchain=$(GCC_TOOLCHAIN) > endif > -ifeq ($(if $(AS),$(shell $(AS) --version 2>&1 | head -n 1 | grep clang)),) > +ifneq ($(LLVM_IA),1) > CLANG_FLAGS += -no-integrated-as > endif > CLANG_FLAGS += -Werror=unknown-warning-option > -- > 2.17.1 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200407184336.14612-1-masahiroy%40kernel.org. -- Thanks, ~Nick Desaulniers