From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BA83C32753 for ; Wed, 14 Aug 2019 22:20:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F28A2067D for ; Wed, 14 Aug 2019 22:20:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bIzCRgoq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728960AbfHNWUr (ORCPT ); Wed, 14 Aug 2019 18:20:47 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:41038 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728461AbfHNWUp (ORCPT ); Wed, 14 Aug 2019 18:20:45 -0400 Received: by mail-pl1-f193.google.com with SMTP id m9so232450pls.8 for ; Wed, 14 Aug 2019 15:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3k2w+T8PpskZpxccjtIiizfMIZhjmdjjp0d3COyTRJs=; b=bIzCRgoqfzNuUan1EfvB7NRSozZHajM22ukZLoilzYM9sYiJ7YkDvmA7Uj+9V3whQX tVwoUOufC9BTkAMrQC/rHvkb/exsHErFgJVr/8W7KT829V0wEHH9QAxZdmZ/ErITekS6 xrKE/Bq6vysHbTrERMP3oECXC0pPuqF/A4lnVBELZNj6IgYErrd6+O2HP/vitjEgPg/G Vo3XjVH1cvHMNyp/jwUDdyb50ZiaJxDo6aTcH/2RYATRNkXzQBQZglJb7q5MJyn2amFZ e2uUqZNKxy7OtuBUudolHQGGHryuTumSWmufu1hM+Awk5W4Y9ddcKD4aXMaQEHtNXxkv B8Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3k2w+T8PpskZpxccjtIiizfMIZhjmdjjp0d3COyTRJs=; b=ppVyGUmXQEZ5xp+/i9zgcpc/9iOpOc4Lg+JyjKYjU7L9GF37uV7Fsh1KpSBXNoKEpW 42HyR9WSeC9ti1Why/yUflVbaRGoOuMs/RN3LH1+FF2oxz5tjZx8zolLG64LC7NUgb3I pSetPTIWfVFOQm24Xn1I2AX0vfU/0H2rPAzQ1o1fISPSpZACuwQCSKHJAiJpAqdl0AgX /hyMJ5me/jZSVDwd87/t6cXAwnby/vIlEzk5woJPqn3mBDEQsQW8R4Uw4p++7gTipCPQ XtcCy+R69IyJMLbdMNvDSH5aLl5tbH7xFT3o/t8DhqIQNkoPxikYlxOswbwOX4+37WPF O0gg== X-Gm-Message-State: APjAAAWcMtxKQuJh9YDnRIVcge480uBUpCGuaLkb3DItlg/N9Y9ADXWi HJYBKtiE4Y/9AXs4NYtsd0dcz+hcLOq1XgL8Ty/mww== X-Google-Smtp-Source: APXvYqxHrSJ2tRfUqC4Ul74AEgggKrkSwf6kd2vyhl5jNkzvxCgzLD0h2XP16ofmSNmQ6rstXRsNaFKQHmMH2KlVrOE= X-Received: by 2002:a17:902:a9c3:: with SMTP id b3mr1454831plr.179.1565821244245; Wed, 14 Aug 2019 15:20:44 -0700 (PDT) MIME-Version: 1.0 References: <20190812215052.71840-1-ndesaulniers@google.com> <20190812215052.71840-12-ndesaulniers@google.com> <20190813082744.xmzmm4j675rqiz47@willie-the-truck> <20190813170829.c3lryb6va3eopxd7@willie-the-truck> In-Reply-To: <20190813170829.c3lryb6va3eopxd7@willie-the-truck> From: Nick Desaulniers Date: Wed, 14 Aug 2019 15:20:33 -0700 Message-ID: Subject: Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h To: Will Deacon , Miguel Ojeda Cc: Andrew Morton , Sedat Dilek , Josh Poimboeuf , Yonghong Song , clang-built-linux , Catalin Marinas , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Andrey Konovalov , Greg Kroah-Hartman , Enrico Weigelt , Suzuki K Poulose , Thomas Gleixner , Masayoshi Mizuma , Shaokun Zhang , Alexios Zavras , Allison Randal , Linux ARM , linux-kernel , Network Development , bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 13, 2019 at 10:08 AM Will Deacon wrote: > > On Tue, Aug 13, 2019 at 02:36:06PM +0200, Miguel Ojeda wrote: > > On Tue, Aug 13, 2019 at 10:27 AM Will Deacon wrote: > > > On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote: > > > > GCC unescapes escaped string section names while Clang does not. Because > > > > __section uses the `#` stringification operator for the section name, it > > > > doesn't need to be escaped. > > > > > > > > This antipattern was found with: > > > > $ grep -e __section\(\" -e __section__\(\" -r > > > > > > > > Reported-by: Sedat Dilek > > > > Suggested-by: Josh Poimboeuf > > > > Signed-off-by: Nick Desaulniers > > > > --- > > > > arch/arm64/include/asm/cache.h | 2 +- > > > > arch/arm64/kernel/smp_spin_table.c | 2 +- > > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > Does this fix a build issue, or is it just cosmetic or do we end up with > > > duplicate sections or something else? > > > > This should be cosmetic -- basically we are trying to move all users > > of current available __attribute__s in compiler_attributes.h to the > > __attr forms. I am also adding (slowly) new attributes that are > > already used but we don't have them yet in __attr form. This lone patch of the series is just cosmetic, but patch 14/16 fixes a real boot issue: https://github.com/ClangBuiltLinux/linux/issues/619 Miguel, I'd like to get that one landed ASAP; the rest are just for consistency. > > > > > Happy to route it via arm64, just having trouble working out whether it's > > > 5.3 material! Thanks! https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?h=for-next/core&id=80d838122643a09a9f99824adea4b4261e4451e6 > > > > As you prefer! Those that are not taken by a maintainer I will pick up > > and send via compiler-attributes. Miguel, how do you want to take the rest of these patches? Will picked up the arm64 one, I think the SuperH one got picked up. There was feedback to add more info to individual commits' commit messages. I kept these tree wide changes separate to improve the likelihood that they'd backport to stable cleanly, but could always squash if you'd prefer to have 1 patch instead of a series. Just let me know. -- Thanks, ~Nick Desaulniers