From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01E97CA9ECB for ; Thu, 31 Oct 2019 17:28:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD27920650 for ; Thu, 31 Oct 2019 17:28:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gpOK87CJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728996AbfJaR24 (ORCPT ); Thu, 31 Oct 2019 13:28:56 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:42751 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728561AbfJaR24 (ORCPT ); Thu, 31 Oct 2019 13:28:56 -0400 Received: by mail-pl1-f194.google.com with SMTP id j12so1033881plt.9 for ; Thu, 31 Oct 2019 10:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6m++fSIeBZqcJkeOt8/Shjtnuo+Q7rdlGD1c3YsGie4=; b=gpOK87CJRb754Y2+vKxaKrfCJA4dCHJjEnrqUCTDyVh8ydN+OuHauU0RzeuaqcPPqz 8NeU4ITnb3rEWRmC3gSLVjVWnVesKGM1oyS/yh1NVuxjprhNF47oEx8mkDlnMjX5UGW5 JiROU1AiJ8h+8ySX34AX4ACrznfiflDYVAMZM4a1Ar3B/7Tg5JN2SEMWHv3bPcn4f9qv R2QTmF9UEBbN86wcvkIxoBSkI67Kwa+sSYeRuJikIaYcxF+xfeewIHa6mGB7ZX5LMek1 44Q7BbPEQbga/h7AhHpE5nwsTjoLhikG9VeHjhjiil8JtMG8WHEWP49lOfvP4ttwUXFY /yWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6m++fSIeBZqcJkeOt8/Shjtnuo+Q7rdlGD1c3YsGie4=; b=q+RaEWHgZ0ZGTMhlQqCVxfNCrnZksG9SOCVIj4B2cKfMwW5N+OpPwhESIYDMDOmOFv VgnAJ9TlPTk9uh9l+F/8/oV1Y0qtkSBhG+uNRGgqhCK7HlV9UGmJzqYDzLmbXd6ZG6ii kZj0CblXk3apeTE88OKJL6bvUAi0GdrqG/vgSE6zXn45WAEbEbwxYjwapiWLBuehNHUS b4ke01hIOjK5rVmCUf355tP0TXJcrQ0qSWeOQ6SEwB+Gaupq7N5BAmTIGsjHIhFwiDep QOTtv0YEXm1LRSkhhuHkeN9F/OL+li0OKiP29K8xPjDct1SLQvM0zjrgNoRRopdJCUE9 ZNLA== X-Gm-Message-State: APjAAAXTKqNdd00gpst5zX1S2QQBG8j6bsVQjin7pK01aO/dckomkRXy sH+xhi+6mZMfyLr/uDtnqqhhCcz+LWIe7ZVQv/pAWA== X-Google-Smtp-Source: APXvYqz/zaeuQgN6H9iXB6EC1IiRwlJeGkd2Ujt7JrblzBduB3a+f7TFswdMNV3RtEu438byzq5VFDkdG5vZyTUTeko= X-Received: by 2002:a17:902:9b83:: with SMTP id y3mr7530087plp.179.1572542935004; Thu, 31 Oct 2019 10:28:55 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-16-samitolvanen@google.com> In-Reply-To: <20191031164637.48901-16-samitolvanen@google.com> From: Nick Desaulniers Date: Thu, 31 Oct 2019 10:28:43 -0700 Message-ID: Subject: Re: [PATCH v3 15/17] arm64: vdso: disable Shadow Call Stack To: Sami Tolvanen Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 31, 2019 at 9:47 AM wrote: I've gotten slapped down before for -ENOCOMMITMSG; maybe include more info if there's a v4? Maintainers can take the safe position of always saying "no," so it is useful to always provide an answer to the implicit question, "why should I take this patch?" > > Signed-off-by: Sami Tolvanen > --- > arch/arm64/kernel/vdso/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile > index dd2514bb1511..a87a4f11724e 100644 > --- a/arch/arm64/kernel/vdso/Makefile > +++ b/arch/arm64/kernel/vdso/Makefile > @@ -25,7 +25,7 @@ ccflags-y += -DDISABLE_BRANCH_PROFILING > > VDSO_LDFLAGS := -Bsymbolic > > -CFLAGS_REMOVE_vgettimeofday.o = $(CC_FLAGS_FTRACE) -Os > +CFLAGS_REMOVE_vgettimeofday.o = $(CC_FLAGS_FTRACE) -Os $(CC_FLAGS_SCS) Looks like vgettimeofday is the only remaining source written in C, so we shouldn't need to strip it from other assembly source files. Reviewed-by: Nick Desaulniers > KBUILD_CFLAGS += $(DISABLE_LTO) > KASAN_SANITIZE := n > UBSAN_SANITIZE := n > -- > 2.24.0.rc0.303.g954a862665-goog > -- Thanks, ~Nick Desaulniers