From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DFF8C433E1 for ; Mon, 20 Jul 2020 19:48:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 394FB22482 for ; Mon, 20 Jul 2020 19:48:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DpBxcSV7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731078AbgGTTsv (ORCPT ); Mon, 20 Jul 2020 15:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731013AbgGTTsu (ORCPT ); Mon, 20 Jul 2020 15:48:50 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A20EC0619D2 for ; Mon, 20 Jul 2020 12:48:50 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id f16so414254pjt.0 for ; Mon, 20 Jul 2020 12:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p7rC2iD3wo0oNQ6k3NcAdhyJnspg3W/7FWg9FWMeNCc=; b=DpBxcSV7dp+Uc3878y4A6FTCUnFg7UG7BvM3+wUETqt1tCV6dq6NhTzzVJBusLN0BH oyC54D1n0lopR3swYEIlBOZPl6K6+wqRXjnmyxduQT2fnWsISQotQ5fjEK+1TX/3UN8L uUdwlioR+bOjGPkuiLXs0/D+vWLQvDlKRs06cilMmpKcfaFNY7kBiLF2vm6qSpJuwW+b x1krJjjfdhKj6YX6g6t174Ir9reWw0gL2n3OjatTzgu8HbceH4I6HT2HpfaHBlej0Vnq KKCHXokzyH2xz73HLkeIMq42uADogFdiLXelov1POApIiYqTmoAG0zoF6Mg/hF+S7zMY sFVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p7rC2iD3wo0oNQ6k3NcAdhyJnspg3W/7FWg9FWMeNCc=; b=E9uyAppredV7s5yptSBaIpQ+7YYhffhNi23ZCpAMQ9Wa/EOWkbRuRAp4tQL4HxHTsK 7Z+dnLcXDFBRhjBanGo+ekijmtuL6KlklOtQk4I7LRArqhjgOs4HhTG2sFAVitIA95sN yspS0oKYsFdy06pZ3RIvcs7wZafzfbaaN3aT5UrKqv3bb7Fs95yTyTumxRYJgOas5NE5 3Rq2k593mnh6jaH0FgDJo1hPPtl30ePLfSZfONCksbfSohQ08sajpQgjHJ8q+ZgxigYr sYAkMqBxs2dZoCmzLANps1jVT0+j6V17m9byUR0xqXcvSiaYBpoPDRXjB3gP7Ikoei4x drZA== X-Gm-Message-State: AOAM531f0Hje0gtowXGUIcT7oftU7SHjkRi2uMJ6l/gBiOupS0pJ5tVN kyh22W9FZJ9obvu8/qkz/1xdPO3RS0cOO2XgwFDFTQ== X-Google-Smtp-Source: ABdhPJwICSn8NvlDtu0svKODEjk5OCN18c6+8Gc45Ed6tmzqHVHxoTL+znXBzO87NHsorhJrLUGH4hcsDS2kKu1JykE= X-Received: by 2002:a17:90a:30ea:: with SMTP id h97mr1031428pjb.32.1595274529468; Mon, 20 Jul 2020 12:48:49 -0700 (PDT) MIME-Version: 1.0 References: <20200708230402.1644819-1-ndesaulniers@google.com> In-Reply-To: From: Nick Desaulniers Date: Mon, 20 Jul 2020 12:48:38 -0700 Message-ID: Subject: Re: [PATCH v2 0/2 net] bitfield.h cleanups To: "David S . Miller" Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , oss-drivers@netronome.com, Network Development , LKML , Jakub Kicinski , Alex Elder Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2020 at 11:23 AM Nick Desaulniers wrote: > > On Wed, Jul 8, 2020 at 4:04 PM Nick Desaulniers wrote: > > > > Two patches, one that removes a BUILD_BUG_ON for a case that is not a > > compile time bug (exposed by compiler optimization). > > > > The second is a general cleanup in the area. > > > > I decided to leave the BUILD_BUG_ON case first, as I hope it will > > simplify being able to backport it to stable, and because I don't think > > there's any type promotion+conversion bugs there. > > > > Though it would be nice to use consistent types widths and signedness, > > equality against literal zero is not an issue. > > > > Jakub Kicinski (1): > > bitfield.h: don't compile-time validate _val in FIELD_FIT > > > > Nick Desaulniers (1): > > bitfield.h: split up __BF_FIELD_CHECK macro > > > > .../netronome/nfp/nfpcore/nfp_nsp_eth.c | 11 ++++---- > > include/linux/bitfield.h | 26 +++++++++++++------ > > 2 files changed, 24 insertions(+), 13 deletions(-) > > > > -- > > 2.27.0.383.g050319c2ae-goog > > > > Hey David, when you have a chance, could you please consider picking > up this series? > -- Hi David, bumping for review. -- Thanks, ~Nick Desaulniers